Login

mikeh · 2011-12-07, 05:10:52

I would like to know where the following plugin hooks are launched.. They do not seem to work the way I understand they should.

Hook 1: settings-website
Hook 2: settings-user

I would think that these 2 hooks would be launched right before the files are created.

Ex below:

Instead of

Code:
# create website xml file

        createBak($wfile, GSDATAOTHERPATH, GSBACKUPSPATH.'other/');

        $xmls = new SimpleXMLExtended('<item></item>');

        $note = $xmls->addChild('SITENAME');

        $note->addCData($SITENAME);

        $note = $xmls->addChild('SITEURL');

        $note->addCData($SITEURL);

        $note = $xmls->addChild('TEMPLATE');

        $note->addCData($TEMPLATE);

        $xmls->addChild('PRETTYURLS', $PRETTYURLS);

        $xmls->addChild('PERMALINK', $PERMALINK);

        if (! XMLsave($xmls, GSDATAOTHERPATH . $wfile) ) {

            $error = i18n_r('CHMOD_ERROR');

        }

I would expect it to be

Code:
# create website xml file

        createBak($wfile, GSDATAOTHERPATH, GSBACKUPSPATH.'other/');

        $xmls = new SimpleXMLExtended('<item></item>');

        $note = $xmls->addChild('SITENAME');

        $note->addCData($SITENAME);

        $note = $xmls->addChild('SITEURL');

        $note->addCData($SITEURL);

        $note = $xmls->addChild('TEMPLATE');

        $note->addCData($TEMPLATE);

        $xmls->addChild('PRETTYURLS', $PRETTYURLS);

        $xmls->addChild('PERMALINK', $PERMALINK);

                <?php exec_action('settings-website'); ?>    

        if (! XMLsave($xmls, GSDATAOTHERPATH . $wfile) ) {

            $error = i18n_r('CHMOD_ERROR');

        }

Am I misinterpreting the use of these hooks?

***n00dles101*** · 2011-12-07, 05:22:00

Good catch Mike, looks like they were ommited from the code.

I've added them to the SVN

mikeh · 2011-12-07, 05:25:10

n00dles101 Wrote:Good catch Mike, looks like they were ommited from the code.

I've added them to the SVN

Awesome, thanks!
I can fix the biggest issue with my multiuser plugin.

Carlos · 2011-12-07, 06:21:02

n00dles101 Wrote:Good catch Mike, looks like they were ommited from the code.

Both hooks were intentionally removed in r258: http://code.google.com/p/get-simple-cms/...ttings.php
This is what Chris commented:

Quote:i also removed some hooks that allowed plugins to put new data into the
website.xml and {user_id}.xml. I dont see the value in allowing authors to do
this, and could potentially be lethal to a site anyway...

mikeh · 2011-12-07, 06:23:37

Carlos Wrote:
n00dles101 Wrote:Good catch Mike, looks like they were ommited from the code.

Both hooks were intentionally removed in r258: http://code.google.com/p/get-simple-cms/...ttings.php
This is what Chris commented:

Quote:i also removed some hooks that allowed plugins to put new data into the
website.xml and {user_id}.xml. I dont see the value in allowing authors to do
this, and could potentially be lethal to a site anyway...

Well at that time I don't believe multi user capabilities existed. Now it is almost detrimental for multi-user purposes.

Login
Username:
Password:	Lost Password?
	Remember me