• From: Dublin, Ireland
  • Registered: 2009-08-07
  • Posts: 642
  • Reputation : 15

Topic: Theme Editor

With the new release of GetSimple 3.1 not too far away we have introduced a full theme editor in the system.

The following features have been enabled in the latest Beta Featured release r602.

Features of the new editor include;

  • Full syntax highlighting for JS/PHP/HTML/CSS files

  • Code folding, click the gutter or CTRL-Q to fold your code.

  • Search and replace -

    Ctrl-F / Cmd-F
    Start searching

    Ctrl-G / Cmd-G
    Find next

    Shift-Ctrl-G / Shift-Cmd-G
    Find previous

    Ctrl-R / Cmd-Option-F
    Replace

    Shift-Ctrl-R / Shift-Cmd-Option-F
    Replace all

  • Full screen editing , Press F11 (or ESC in Safari on Mac OS X) when cursor is in the editor to toggle full screen editing.

Currently working on The Matrix Plugin...

n00dles101's Website

  • Connie
  • Connie
  • GetSimple Moderator
  • Offline
  • From: Hamburg + Gribow
  • Registered: 2011-02-28
  • Posts: 2,022
  • Reputation : 22

Re: Theme Editor

that sounds really great, I will check it

which version is it?

|--
Die deutsche GetSimple-Webseite: http://www.Get-Simple.de = the german Get-Simple-Website!
Das deutschsprachige GetSimple-(Unter-)Forum:   http://get-simple.info/forum/forum/16/german-deutsch/
  • From: Dublin, Ireland
  • Registered: 2009-08-07
  • Posts: 642
  • Reputation : 15

Re: Theme Editor

@Connie, its using Codemirror 2 and has been included in the last few beta releases.
This additonal features are only in the new Beta download r602.

Currently working on The Matrix Plugin...

n00dles101's Website

  • Connie
  • Connie
  • GetSimple Moderator
  • Offline
  • From: Hamburg + Gribow
  • Registered: 2011-02-28
  • Posts: 2,022
  • Reputation : 22

Re: Theme Editor

the official red download-button  leads ot Beta-Version 594, that was misleading for me (I am not so familiar with github, sourceforge etc.)

Thanks for the info

|--
Die deutsche GetSimple-Webseite: http://www.Get-Simple.de = the german Get-Simple-Website!
Das deutschsprachige GetSimple-(Unter-)Forum:   http://get-simple.info/forum/forum/16/german-deutsch/
  • From: Dublin, Ireland
  • Registered: 2009-08-07
  • Posts: 642
  • Reputation : 15

Re: Theme Editor

I'll get Chris to update that link.. I don't have access...

That version should have the basic editor, I've added these additions to the new version.

Currently working on The Matrix Plugin...

n00dles101's Website

  • calmos
  • calmos
  • GetSimple Student
  • Offline
  • From: Lille (fr)
  • Registered: 2011-04-30
  • Posts: 27
  • Reputation : 1

Re: Theme Editor

Very promising :))
For the time being, highlighting works well but the other ones do not.
I just tried this on a fresh GS 3.1 r602, using Firefox 9.0 and Chrome 16, Win XP.

...sur la rampe de lancement ::
       http://getsimple.fr
       :: on the launchpad...
  • Carlos
  • Carlos
  • GetSimple Fan
  • Offline
  • From: Sant Joan d'Alacant, ES
  • Registered: 2010-03-13
  • Posts: 598
  • Reputation : 27

Re: Theme Editor

FYI there already existed a nice plugin by mvlcek that does more or less the same, but also for component editing: Theme highlighter

Carlos's Website

8 Reply by datiswous (edited by datiswous 2012-02-25 18:53:23)

  • From: Amsterdam
  • Registered: 2011-02-14
  • Posts: 191
  • Reputation : 1

Re: Theme Editor

Code folding thing is cool.


Doe this also include a solution for the:

Maintaining Page Scroll Position after save or refresh

issue? (the issue is that it doesn't do so)


Edit: Nope

datiswous's Website

  • From: USA
  • Registered: 2011-09-14
  • Posts: 246
  • Reputation : 2

Re: Theme Editor

Carlos wrote:

FYI there already existed a nice plugin by mvlcek that does more or less the same, but also for component editing: Theme highlighter

Yes, if you consider implementing this, I would definitively like to see it applied to all code inputs. I love my Theme highlighter + custom admin css. Components are necessary, also a hook to add it to plugin code fields would be awesome as well.

Admin Tagging GUI Plugin
TOC / Anchors Plugin
Page Time
Development Suite

shawn_a's Website

  • Carlos
  • Carlos
  • GetSimple Fan
  • Offline
  • From: Sant Joan d'Alacant, ES
  • Registered: 2010-03-13
  • Posts: 598
  • Reputation : 27

Re: Theme Editor

shawn_a wrote:

also a hook to add it to plugin code fields would be awesome as well.

That's a very good idea!

Carlos's Website

  • Carlos
  • Carlos
  • GetSimple Fan
  • Offline
  • From: Sant Joan d'Alacant, ES
  • Registered: 2010-03-13
  • Posts: 598
  • Reputation : 27

Re: Theme Editor

@n00dles101

I'm afraid the theme editor is only working fine for css files - php and js files are not coloured properly.

Paste the code from e.g. template.php in http://codemirror.net/1/contrib/php/ and see the difference.

(I don't know codemirror, but it may be that you're not setting the mode argument or something, depending on the type of file.)

Carlos's Website

  • mvlcek
  • mvlcek
  • GetSimple Master
  • Offline
  • Registered: 2011-01-08
  • Posts: 1,341
  • Reputation : 66

Re: Theme Editor

Carlos wrote:

@n00dles101

I'm afraid the theme editor is only working fine for css files - php and js files are not coloured properly.

Paste the code from e.g. template.php in http://codemirror.net/1/contrib/php/ and see the difference.

(I don't know codemirror, but it may be that you're not setting the mode argument or something, depending on the type of file.)

I had to patch CodeMirror for the Theme Highlighter plugin to correctly work with e.g. inline php code.

I18N, I18N Search, I18N Gallery, I18N Special Pages - essential plugins for multi-language sites.

mvlcek's Website

  • From: Amsterdam
  • Registered: 2011-02-14
  • Posts: 191
  • Reputation : 1

Re: Theme Editor

I updated mvlcek's Theme Highlighter plugin (and activated it), but now the code folding doesn't work anymore.

Wouldn't it be better to merge the features of mvlek's plugin into the core features instead of basically 2 projects?

datiswous's Website

  • From: Rohnert Park, ca
  • Registered: 2011-12-31
  • Posts: 19
  • Reputation : 1

Re: Theme Editor

datiswous wrote:

Code folding thing is cool.


Doe this also include a solution for the:

Maintaining Page Scroll Position after save or refresh


issue? (the issue is that it doesn't do so)


Edit: Nope

I just wrote a plugin based on the code which saves through ajax. http://get-simple.info/extend/plugin/thajax/426/

Very nice editor by the way, I hope you don't mind that I based a lot of my code on it. Keep up the good work. Get-Simple is turning into my favorite CMS.

www.ericwooley.com
5wooley4@gmail.com - Let me know if you need any help with any of my plugins, or just help in general. I'll always help if i can.

Beware, Im just a drunken college student. I may throw up at any time.

5wooley4's Website

15 Reply by datiswous (edited by datiswous 2012-04-13 08:12:11)

  • From: Amsterdam
  • Registered: 2011-02-14
  • Posts: 191
  • Reputation : 1

Re: Theme Editor

5wooley4 wrote:

I just wrote a plugin based on the code which saves through ajax. http://get-simple.info/extend/plugin/thajax/426/

Very nice editor by the way, I hope you don't mind that I based a lot of my code on it. Keep up the good work. Get-Simple is turning into my favorite CMS.

You do know the (new) Get-Simple editor is based on Codemirror 2?:

http://codemirror.net/

datiswous's Website

  • Carlos
  • Carlos
  • GetSimple Fan
  • Offline
  • From: Sant Joan d'Alacant, ES
  • Registered: 2010-03-13
  • Posts: 598
  • Reputation : 27

Re: Theme Editor

Found another issue: if you select text, it is not highlighted, doesn't change its background colour.

Carlos's Website

  • Carlos
  • Carlos
  • GetSimple Fan
  • Offline
  • From: Sant Joan d'Alacant, ES
  • Registered: 2010-03-13
  • Posts: 598
  • Reputation : 27

Re: Theme Editor

Carlos wrote:

if you select text, it is not highlighted, doesn't change its background colour.

Did anyone check this? Happens to me with 3.1.1 beta, but not with 3.1

Carlos's Website

  • From: Dublin, Ireland
  • Registered: 2009-08-07
  • Posts: 642
  • Reputation : 15

Re: Theme Editor

@Carlos, something wrong with the codemirror bundle, will have this fixed tonight.

Currently working on The Matrix Plugin...

n00dles101's Website

  • From: Dublin, Ireland
  • Registered: 2009-08-07
  • Posts: 642
  • Reputation : 15

Re: Theme Editor

This should be sorted in the latest SVN version, it was a simple CSS issue...

Currently working on The Matrix Plugin...

n00dles101's Website

  • Carlos
  • Carlos
  • GetSimple Fan
  • Offline
  • From: Sant Joan d'Alacant, ES
  • Registered: 2010-03-13
  • Posts: 598
  • Reputation : 27

Re: Theme Editor

It looks like it works ok when you select text across several lines, but if you only select some text in the current line, it is not highlighted (or maybe the selected text has the same background color as the active line: #F0FCFF)

Carlos's Website