GetSimple Support Forum

Full Version: VERY inefficient generate_sitemap function
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
I suppose I forgot to report this bug for 3.0, because I rarely use the sitemap feature, thus it's still there in 3.1:
You save the sitemap.xml n-times where n is the number of pages.
The exec_action and saving should be outside the page loop.

As the sitemap is now generated automatically (whenever a page is saved?), this should be fixed as fast as possible.
mvlcek Wrote:I suppose I forgot to report this bug for 3.0, because I rarely use the sitemap feature, thus it's still there in 3.1:
You save the sitemap.xml n-times where n is the number of pages.
The exec_action and saving should be outside the page loop.

As the sitemap is now generated automatically (whenever a page is saved?), this should be fixed as fast as possible.

ooh,

Is this why my page saves are taking forever now ? Or is that the new page cache ?
@shawn_a, how many pages on the site are we talking ?
n00dles101 Wrote:@shawn_a, how many pages on the site are we talking ?
46
And by forever ( slightly exaggerated ) I mean 2-3 seconds more than 3.0