GetSimple Support Forum

Full Version: Change default upload folder
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
I think it would be nice if users would be able to specify the upload folder. If users have multiple sites under one domain, it would be handy to have one folder for all their images, pdf's, etc in a different place.
GetSimple has all a CMS needs and nothing a CMS does not need (generally) ;=)

I think this suggestion will produce a lot of problems with folder permissions etc., I can already imagine the posts here in the forum, asking for help....

Cheers, Connie
i haven't tested it, but you should be able to set the define() variable in /admin/inc/common.php to a specific folder. If that works, we can maybe setup a gsconfig option to set an alternative path (just like we did with the /admin/ folder')
ccagle8 Wrote:i haven't tested it, but you should be able to set the define() variable in /admin/inc/common.php to a specific folder. If that works, we can maybe setup a gsconfig option to set an alternative path (just like we did with the /admin/ folder')

It didn't work but the following code in the upload.php is the cause (I assume).

Code:
if (isset($_GET['path'])) {
    $path = str_replace('../','', $_GET['path']);
    $path = tsl("../data/uploads/".$path);
    $subPath = str_replace('../','', $_GET['path']);
    $subFolder = tsl($subPath);
} else {
    $path = "../data/uploads/";
    $subPath = '';
    $subFolder = '';
}
Has there been any progress in formally adopting this new feature?

I'd like to change my upload folder, but would like to make sure GS won't throw errors back (as tested by datiswous a year ago). Has anyone else toyed with their upload destinations? OR has GS included something in an update?

Thanks.
I don't know if anyone has documented this yet, but this is how I almost successfully changed the admin code to accept a new "upload" directory. I say almost because I haven't really done an extensive test, but everything works so far. Using the changes below, I am able to add/edit/delete directories, upload/delete files, and use the file browser feature of the WYSIWYG system.

If this is truly all that was needed to be done (again, I haven't tested it extensively), then some simple changes to the code in the next release can give people the opportunity to change their uploads directory more easily. It would be nice to simply use the GSDATAUPLOADPATH definition.

NOTE: I'm changing the upload directory from uploads to public in GS version 3.1.2.

IN admin/inc/common.php
  • LINE 52: define('GSDATAUPLOADPATH', GSROOTPATH. 'data/public/');

IN admin/upload.php
  • LINE 20: $path = tsl("../data/public/".$path);
  • LINE 24: $path = "../data/public/";
  • LINE 64: ... <a href="'. $SITEURL .'data/public/'.$subFolder.$base.'">'. $SITEURL .'data/public/'.$subFolder.$base.'</a>';
  • LINE 196: echo '<div class="h5 clearfix"><div class="crumbs">/ <a href="upload.php">public</a> / ';
  • LINE 236: $adm = substr($path . $upload['name'] , 15); // used to be 16

IN admin/image.php
  • LINE 25: $src_folder = '../data/public/';
  • LINE 73: ... <?php echo tsl($SITEURL) .'data/public/'. $subPath. $src; ?> ...
  • LINE 77: ... <?php echo tsl($SITEURL) .'data/public/'. $subPath. $src; ?> ...
  • LINE 78: ... <?php echo tsl($SITEURL) .'data/public/'. $subPath. $src; ?> ...
  • LINE 81: ... <?php echo tsl($SITEURL) .'data/public/'. $subPath. $src; ?> ...

IN admin/filebrowser.php
  • LINE 18: $path = (isset($_GET['path'])) ? "../data/public/".$_GET['path'] : "../data/public/";
  • LINE 27: $fullPath = $sitepath . "data/public/";
  • LINE 129: $adm = substr($path . $upload['name'] , 15); // used to be 16

NOTE
The substr changes relate to the length of the directory name. Uploads has 7 letters, public has 6 letters (so 16-1=15).
Thanks for that.

Is there any reason why the upload path is hard coded and not using GSDATAUPLOADPATH ?
It does in 3.4
(2017-12-09, 00:37:28)shawn_a Wrote: [ rel="nofollow" -> ]It does in 3.4

Thanks Shawn, I had a play around with it last night and almost got there! [Image: biggrin.gif]

But I can wait for 3.4.