Connie Wrote:please, before you offer modifications of the original script and seduce users to install it, check out about the possibilities of CKEDITOR

it is a configuration whether there are linebreaks in the generated code or not

"After playing around with CKeditor I noticed the formatting in HTML source view is not right."

where do you know from what is right and what is wrong????

see here:
http://help.pixelandtonic.com/brandonkelly/topics/how_do_i_set_output_formatting_writer_rules?from_gsfn=true

an example might be:

Code:

CKEDITOR.on( 'instanceReady', function( ev ) {

var blockTags = ['div','h1','h2','h3','h4','h5','h6','p','pre','ul','li','table','td','tr','blockquote'];
var rules = {
indent : false,
breakBeforeOpen : true,
breakAfterOpen : false,
breakBeforeClose : false,
breakAfterClose : false
};

we even have an example in the WIKI:
http://get-simple.info/wiki/how_to:editor_configuration_custom_files#custom_configuration_file

so, please do configure and not modify!!!!!!

SmashArtist Wrote:Also I did not see anything about this in the wiki, I only saw the option to change P to BR. I'm curious though as to why this isn't defaulted in GS? The code formatting was driving my nuts lol.

Connie Wrote:

SmashArtist Wrote:Also I did not see anything about this in the wiki, I only saw the option to change P to BR. I'm curious though as to why this isn't defaulted in GS? The code formatting was driving my nuts lol.

well, please be aware that CKEDITOR is NOT GetSimple!

And which default configuration is the perfect one, who decides?

I think we offer as much information as necessary, because:

we describe in the WIKI how to define personal, special config-files incase you are not satisfied with "advanced" and "options" in the gsconfig.php

but to learn about the CKEDITOR you have to go to the CKEDITOR docs and find out what is possible before you condemn it ;=)

I aplogize for not delivering a 150%-documentation of the editor, I stick with the proverb: give the man a net and he can catch fish himself ;=)

Cheers, Connie

shawn_a Wrote:yeah I think we should add a better default option for this to core, that damn wrapping is idiotic.

I have never seen that syntax in my life, I don't know who came up with the idea that that was legible, i guess it is their excuse for not having real syntax highlighting or formatting. It does not help at all however.

It also likes removing empty lines and newlines for no apparent reason. Removed empty tags, and other annoyances.

I would like to see these all fixed and consider them a nuisance.

I also have a asset update discussion in issues to get it updated to a newer version,

(2013-05-21, 15:57:58)reticent Wrote: How do I have the same function encompass the extra code as previously quoted?

(2013-05-21, 16:10:52)Connie Wrote:

(2013-05-21, 15:57:58)reticent Wrote: How do I have the same function encompass the extra code as previously quoted?

sorry, what is "encompass"? I do not know that word.

you show us a code excerpt which defines the dialogue-functionality.

What was discussed here is the formatting of the HTML-output, quite a different topic.


There is an example in the wiki:
http://get-simple.info/wiki/how_to:editor_configuration_custom_files

and this example file has this part:

PHP Code:

// from  http://help.pixelandtonic.com/brandonkelly/topics/how_do_i_set_output_formatting_writer_rules?from_gsfn=true 
CKEDITOR.on( 'instanceReady', function( ev ) {

var blockTags = ['div','h1','h2','h3','h4','h5','h6','p','pre','ul','li'];
var rules = {
indent : false,
breakBeforeOpen : false,
breakAfterOpen : false,
breakBeforeClose : false,
breakAfterClose : true
};

for (var i=0; i<blockTags.length; i++) {
ev.editor.dataProcessor.writer.setRules( blockTags[i], rules );
}

}); 


and it is exactly described how to use and configure a custom configuration file for the editor

so I think you can start with that. If you have problems, ask!

(2013-05-21, 16:27:17)reticent Wrote: The code suggested has the same function name as already existing code...

(2013-05-21, 20:04:38)Connie Wrote:

(2013-05-21, 16:27:17)reticent Wrote: The code suggested has the same function name as already existing code...

why not? CKEditor uses THAT function to generate the HTML from the textareas

so you have to define what you want to define in this function.

(2013-06-04, 00:49:52)shawn_a Wrote: I propose adding this to 3.2.2 config.js

(2013-06-04, 00:49:52)shawn_a Wrote: I propose adding this to 3.2.2 config.js
...

(2013-06-04, 22:14:24)shawn_a Wrote: Does allowed content work in ck3?

(2013-06-05, 00:42:04)shawn_a Wrote: No it is not.

So explain what this does, and what problem it fixes, or is it a move towards more standardized data, we use cdata in xml now, so stripslashes is no longer required either. Does this mean we would have to do some encoding on output that we might not be already? Or perhaps decoding we are already doing might have to be removed ?