GetSimple Support Forum
SOLVED Font Awesome tags disappear after saving change in source html - Printable Version

+- GetSimple Support Forum (http://get-simple.info/forums)
+-- Forum: GetSimple (http://get-simple.info/forums/forumdisplay.php?fid=3)
+--- Forum: General Questions and Problems (http://get-simple.info/forums/forumdisplay.php?fid=16)
+--- Thread: SOLVED Font Awesome tags disappear after saving change in source html (/showthread.php?tid=6488)



Font Awesome tags disappear after saving change in source html - luya - 2014-06-17

Hello,

The text editor in source format from Get Simple 3.3.2 is unable to preserve the class attribute code from Font Awesome. For example,
Code:
<ul class="fa-ul">
    <li><span class="fa-li fa fa-check"></i> We stand by our work with a 100% guarantee of excellent service</li>
</ul>
Where fa are the classt attribute provided by Font Awesome. Use the example from the url to reproduce the issue.


RE: Font Awesome tags disappear after saving change in source html - shawn_a - 2014-06-17

ckeditor deletes empty tags
add to config.js

// prevent removal of empty tags
CKEDITOR.dtd.$removeEmpty['i'] = false;

there is more details in forums somewhere


RE: Font Awesome tags disappear after saving change in source html - luya - 2014-06-17

Thank you very much. The above solution worked. It will be nice to document the suggestion on the main page.
Regards,

Luya


RE: Font Awesome tags disappear after saving change in source html - Timbow - 2014-11-21

I think it would be good to include it in the core.


RE: Font Awesome tags disappear after saving change in source html - shawn_a - 2014-11-21

It has been for <i> and <span> , but they are commented out, we cannot decide how to handle this and which elements to remove for the user.

// prevent removal of empty inline tags
// CKEDITOR.dtd.$removeEmpty['i'] = false;
// CKEDITOR.dtd.$removeEmpty['span'] = false;

If you guys can vote on what elements should be included and if this is a innocuous change, I will consider it.


RE: Font Awesome tags disappear after saving change in source html - Timbow - 2014-11-21

Font awesome goes with bootstrap - it's pretty popular. atm every upgrade of GS is going to require digging into the admin folder and editing config.js .


RE: Font Awesome tags disappear after saving change in source html - Timbow - 2014-11-21

There is an alternative work-around:

The recommended font awesome syntax is [example]
Code:
<i class="fa fa-camera-retro"></i>
If you take the unicode from the cheat sheet you can use that instead, ie
Code:
<i class="fa">&#xf083;</i>
Seems to work. No empty tags.


RE: Font Awesome tags disappear after saving change in source html - shawn_a - 2014-11-21

No your supposed to use your own config.js
Nice workaround.


RE: Font Awesome tags disappear after saving change in source html - alex_d - 2015-05-02

I'm using &nbsp; to prevent editor to remove the empty tag,


<i class="*** ***">&nbsp;</i>

Alex


RE: Font Awesome tags disappear after saving change in source html - cygnet - 2015-06-24

(2014-11-21, 04:06:18)shawn_a Wrote: It has been for <i> and <span> , but they are commented out, we cannot decide how to handle this and which elements to remove for the user.

// prevent removal of empty inline tags
// CKEDITOR.dtd.$removeEmpty['i'] = false;
// CKEDITOR.dtd.$removeEmpty['span'] = false;

If you guys can vote on what elements should be included and if this is a innocuous change, I will consider it.

Thanks for this solution! That was driving me nuts


RE: Font Awesome tags disappear after saving change in source html - Umbrella - 2016-03-12

shfn_a
It has been for <i> and <span> , but they are commented out, we cannot decide how to handle this and which elements to remove for the user.

// prevent removal of empty inline tags
// CKEDITOR.dtd.$removeEmpty['i'] = false;
// CKEDITOR.dtd.$removeEmpty['span'] = false;

If you guys can vote on what 3 Week Diet elements should be included and if this is a innocuous change, I will consider it.

Does Get Simple support Font Awesome these days or do we still need to configure the config.js every time?


RE: Font Awesome tags disappear after saving change in source html - shawn_a - 2016-03-13

Those 2 specific fixes are already present in stable