(2017-04-25, 04:13:11)hameau Wrote: (Somebody with more insight will probably be along soon.)

The most likely cause of the 'headers already sent' warnings is whitespace after the closing tag (?>) in one of the php files. Start by looking at files that you may have edited – some editors will add a blank line at the end, which you definitely don't want.

You can remove that final php closing tag from the end of such files (the end-of-file implies the end of php) and then the problem can't recur.

Edit to add: What is the origin of that file 'sa_welcome.php' (shown in the warning message)? Is it legitimate or something that has been planted on the server?

(2017-04-25, 06:19:44)gsimon Wrote: headers already sent by (output started at /home/shabonna/public_html/gs/plugins/sa_welcome.php:12) in /home/shabonna/public_html/gs/admin/inc/cookie_functions.php on line 23

(2017-04-25, 07:09:34)hameau Wrote:

(2017-04-25, 06:19:44)gsimon Wrote: headers already sent by (output started at /home/shabonna/public_html/gs/plugins/sa_welcome.php:12) in /home/shabonna/public_html/gs/admin/inc/cookie_functions.php on line 23

The output (which triggers sending the html headers) is started by the bold bit. What is around line 12 of sa_welcome.php? Indeed, what is the contents of sa_welcome.php?

What is the full list of plugins installed (from the Plugins tab in admin backend)?

• Custom Admin CSS
  
• (Innovation theme plugin – depending on the theme requirements, you may have to enable this again)
  
• SA PageTime Plugin
  
• Theme Highlighter
  

(2017-04-25, 21:51:43)hameau Wrote: @Bigin: those lines are already in the file.

(2017-04-25, 22:06:28)Bigin Wrote: nope, they are not, have a closer look at it

(2017-04-25, 22:07:57)shawn_a Wrote: Did you try just turning off php errors display? Or did you enable them to debug the actual issue? Errors rather notices and warnings are not errors but they will break cookies and ajax if you have them enables on production sites

(2017-04-25, 21:51:43)hameau Wrote: Oh, my! What have you inherited? (Aside: if you wrap code with the tags [ code ] ... [ /code ] – leave out the spaces – you get a much more readable result.)

If you haven't already, make a full backup of what you have at the moment (e.g., ftp to your computer).

That sa_welcome.php file is clearly a hacked-together plugin to provide custom tabs for managing litters, but without much finesse. At least remove the closing php tag at the end of the file and change the plugin name and description to something relevant.

You have two versions of the Item(s) Manager, which is unlikely to be a good thing. Disable one of them (probably the older one – but you may not be able to go back).

Disable non-essential plugins:

• Custom Admin CSS
  
• (Innovation theme plugin – depending on the theme requirements, you may have to enable this again)
  
• SA PageTime Plugin
  
• Theme Highlighter
  

You still have a couple of outdated plugins, so bring those up to date.

I have no experience of the Items Manager plugins, so I can't help you there. I don't know what the implications are of having two versions installed.

If this site were my responsibility, I'd look at migrating the existing content to a fresh installation of GS, but there may be other customisations under the skin, so it's going to be a risky business. Good luck!

@Bigin: those lines are already in the file.

Edit to add: Crossed with Shawn's post. @shawn_a: how could you! ;P

(2017-04-25, 22:07:57)shawn_a Wrote: Did you try just turning off php errors display? Or did you enable them to debug the actual issue? Errors rather notices and warnings are not errors but they will break cookies and ajax if you have them enables on production sites

(2017-04-25, 21:51:43)hameau Wrote: Oh, my! What have you inherited? (Aside: if you wrap code with the tags [ code ] ... [ /code ] – leave out the spaces – you get a much more readable result.)

If you haven't already, make a full backup of what you have at the moment (e.g., ftp to your computer).

That sa_welcome.php file is clearly a hacked-together plugin to provide custom tabs for managing litters, but without much finesse. At least remove the closing php tag at the end of the file and change the plugin name and description to something relevant.

You have two versions of the Item(s) Manager, which is unlikely to be a good thing. Disable one of them (probably the older one – but you may not be able to go back).

Disable non-essential plugins:

• Custom Admin CSS
  
• (Innovation theme plugin – depending on the theme requirements, you may have to enable this again)
  
• SA PageTime Plugin
  
• Theme Highlighter
  

You still have a couple of outdated plugins, so bring those up to date.

I have no experience of the Items Manager plugins, so I can't help you there. I don't know what the implications are of having two versions installed.

If this site were my responsibility, I'd look at migrating the existing content to a fresh installation of GS, but there may be other customisations under the skin, so it's going to be a risky business. Good luck!

@Bigin: those lines are already in the file.

Edit to add: Crossed with Shawn's post. @shawn_a: how could you! ;P

(2017-04-25, 22:07:57)shawn_a Wrote: Did you try just turning off php errors display? Or did you enable them to debug the actual issue? Errors rather notices and warnings are not errors but they will break cookies and ajax if you have them enables on production sites

(2017-04-26, 00:48:32)Bigin Wrote: Do you get any more php errors after it? I think, that's the old Item Manager that causes the error, this PlugIn was really bugged.

PS. try to disable all your plugins

(2017-04-26, 01:51:31)shawn_a Wrote: you can probably ignore the other suggestions in this thread, ...

(2017-04-25, 21:51:43)hameau Wrote: Oh, my! What have you inherited? (Aside: if you wrap code with the tags [ code ] ... [ /code ] – leave out the spaces – you get a much more readable result.)

If you haven't already, make a full backup of what you have at the moment (e.g., ftp to your computer).

That sa_welcome.php file is clearly a hacked-together plugin to provide custom tabs for managing litters, but without much finesse. At least remove the closing php tag at the end of the file and change the plugin name and description to something relevant.

You have two versions of the Item(s) Manager, which is unlikely to be a good thing. Disable one of them (probably the older one – but you may not be able to go back).

Disable non-essential plugins:

• Custom Admin CSS
  
• (Innovation theme plugin – depending on the theme requirements, you may have to enable this again)
  
• SA PageTime Plugin
  
• Theme Highlighter
  

You still have a couple of outdated plugins, so bring those up to date.

I have no experience of the Items Manager plugins, so I can't help you there. I don't know what the implications are of having two versions installed.

If this site were my responsibility, I'd look at migrating the existing content to a fresh installation of GS, but there may be other customisations under the skin, so it's going to be a risky business. Good luck!

@Bigin: those lines are already in the file.

Edit to add: Crossed with Shawn's post. @shawn_a: how could you! ;P

(2017-04-25, 22:07:57)shawn_a Wrote: Did you try just turning off php errors display? Or did you enable them to debug the actual issue? Errors rather notices and warnings are not errors but they will break cookies and ajax if you have them enables on production sites

(2017-04-26, 04:01:07)shawn_a Wrote: headers were output by a php warning, you can fix it, but its not the cause of the problem, one does not need to fix every php notice and warning, they are not errors, they are verbose debugging for development. Turn php error dispaly off on production websites, it should never be on period.

If you have the time to resolve all warnings and notices then do so, but it is not an error condition typically. I am more interested in finding the main errors, and working backwards from there. The rest is noise.

NOTES about site
but as said, do NOT upgrade plugins, you will definitely break something, not sure which ones are modified, I do know item manager was my custom version made specifically for this site.

Also your site uses a custom gs loader, to load GS into an external site, basically a stripped down customized version of index.php for including into the main site static html. ( GS does not support this natively in 3.3.x version, planned for future though )

disable debug mode, see what errors you get when uploading in console, i am also curious about that JS fatal error

if you want to shut up the notice
add

Code:

$SA_PLUGIN_ID = "";

I do not think $SA_PLUGINPATH is actually used, maybe check though.
no idea how I left that in there not defined.

(2017-04-25, 21:51:43)hameau Wrote: Oh, my! What have you inherited? (Aside: if you wrap code with the tags [ code ] ... [ /code ] – leave out the spaces – you get a much more readable result.)

If you haven't already, make a full backup of what you have at the moment (e.g., ftp to your computer).

That sa_welcome.php file is clearly a hacked-together plugin to provide custom tabs for managing litters, but without much finesse. At least remove the closing php tag at the end of the file and change the plugin name and description to something relevant.

You have two versions of the Item(s) Manager, which is unlikely to be a good thing. Disable one of them (probably the older one – but you may not be able to go back).

Disable non-essential plugins:

• Custom Admin CSS
  
• (Innovation theme plugin – depending on the theme requirements, you may have to enable this again)
  
• SA PageTime Plugin
  
• Theme Highlighter
  

You still have a couple of outdated plugins, so bring those up to date.

I have no experience of the Items Manager plugins, so I can't help you there. I don't know what the implications are of having two versions installed.

If this site were my responsibility, I'd look at migrating the existing content to a fresh installation of GS, but there may be other customisations under the skin, so it's going to be a risky business. Good luck!

@Bigin: those lines are already in the file.

Edit to add: Crossed with Shawn's post. @shawn_a: how could you! ;P

(2017-04-25, 22:07:57)shawn_a Wrote: Did you try just turning off php errors display? Or did you enable them to debug the actual issue? Errors rather notices and warnings are not errors but they will break cookies and ajax if you have them enables on production sites

(2017-04-26, 22:02:47)shawn_a Wrote: Sounds like your host enabled php errors when they updated. Maybe you can turn it off in cpanel?
If not there are htaccess ways and php ways and a gs way.

Ill look at this createuploader issue

(2017-04-25, 21:51:43)hameau Wrote: Oh, my! What have you inherited? (Aside: if you wrap code with the tags [ code ] ... [ /code ] – leave out the spaces – you get a much more readable result.)

If you haven't already, make a full backup of what you have at the moment (e.g., ftp to your computer).

That sa_welcome.php file is clearly a hacked-together plugin to provide custom tabs for managing litters, but without much finesse. At least remove the closing php tag at the end of the file and change the plugin name and description to something relevant.

You have two versions of the Item(s) Manager, which is unlikely to be a good thing. Disable one of them (probably the older one – but you may not be able to go back).

Disable non-essential plugins:

• Custom Admin CSS
  
• (Innovation theme plugin – depending on the theme requirements, you may have to enable this again)
  
• SA PageTime Plugin
  
• Theme Highlighter
  

You still have a couple of outdated plugins, so bring those up to date.

I have no experience of the Items Manager plugins, so I can't help you there. I don't know what the implications are of having two versions installed.

If this site were my responsibility, I'd look at migrating the existing content to a fresh installation of GS, but there may be other customisations under the skin, so it's going to be a risky business. Good luck!

@Bigin: those lines are already in the file.

Edit to add: Crossed with Shawn's post. @shawn_a: how could you! ;P

(2017-04-25, 22:07:57)shawn_a Wrote: Did you try just turning off php errors display? Or did you enable them to debug the actual issue? Errors rather notices and warnings are not errors but they will break cookies and ajax if you have them enables on production sites

(2017-04-26, 16:59:14)Bigin Wrote: I think it could be a bug in PHP 5.6. The warning corrupting the json response in your uploader.php
The error means: you are sending an empty request. This error occurs when requests with empty parameter is passed.

Solution:
If you are using CGI you have set always_populate_raw_post_data = -1 in the php.ini
Or put the following lines in .htaccess file:

Code:

<IfModule mod_php5.c>
   php_flag always_populate_raw_post_data -1
</IfModule>

And keep php error reporting turned off, items manager and other plugin is still bugged as hell.