Posts: 3,491
Threads: 106
Joined: Mar 2010
Shawn,
Related to this:
http://get-simple.info/forums/showthread.php?tid=5299&pid=40697#pid40697
I've experimented a bit. If you remove this from
caching_functions.php:
Code:
add_action('header', 'getPagesXmlValues',array(true)); // make $pagesArray available to the back
and add this to
get_available_pages (line 627) and
list_pages_json (line 749):
Code:
getPagesXmlValues();
then
pages.xml is loaded only once in pages.php, edit.php, menu-manager.php, and never in other backend pages (that don't need it).
I think that this doesn't break anything.
Posts: 6,267
Threads: 182
Joined: Sep 2011
It is already loaded only once, unless a plugin lazy loads it before the header hook , where are you seeing that this still a problem?
Posts: 3,491
Threads: 106
Joined: Mar 2010
caching_functions.php
Code:
function getPagesXmlValues($chkcount=false){
...
$data = simplexml_load_string($thisfile);
debugLog('pages.xml read'); // ADDED FOR TESTING
I see it's loaded twice in Pages, Edit and Menu-manager.
Once in the rest of admin pages.
Posts: 6,267
Threads: 182
Joined: Sep 2011
Not sure how, you totally skipped the existing return check I that code snippet.
Something could be nullifying your pages array global?
Posts: 6,267
Threads: 182
Joined: Sep 2011
Hmm you are probably right, I think I forgot to remove that hook.
Posts: 15
Threads: 4
Joined: Nov 2013
I like the beta. Not really noticeable differences than release but it works well.
Posts: 6,267
Threads: 182
Joined: Sep 2011
carlos I have no idea how you are having this issue. This was fixed like a month ago, and should have not been an issue in b3.
Posts: 3,491
Threads: 106
Joined: Mar 2010
I checked again with fresh installs.
Code:
$thisfile = file_get_contents($file);
debugLog('pages.xml read'); // TESTING
(caching_functions.php)
pages.xml loaded twice in Page manager and Menu-manager.
Once in the other admin pages.
(I said twice in Edit/create page, but it's once, sorry)
Posts: 6,267
Threads: 182
Joined: Sep 2011
Not on default install, you using nm?
I have tested this with 28 plugins.
Posts: 3,491
Threads: 106
Joined: Mar 2010
Fresh install with no plugins (even default ones disabled). Tested with 3.3.0b3 and develop version.
Debug Console:
Quote:pages.xml read
pages.xml read
on admin/pages.php and admin/menu-manager.php
Posts: 6,267
Threads: 182
Joined: Sep 2011
Posts: 6,267
Threads: 182
Joined: Sep 2011
ok this is probably fixed in develop now
Thanks carlos
I was not seeing this issue cause I was testing i18n still and had it running its own "pages.php"
Posts: 6,267
Threads: 182
Joined: Sep 2011
Beta 4 released
Beta extended to one more test, some last minutes stuff made it in namely ckeditor 3.6.6 to fix IE10 fatal issues.
I also added in some new page filters for dynamic slugs testing, to be finalized in rc1. So see if they are useful.
Should enable any custom slug content or rewriting anything one could want to do.
Posts: 3,491
Threads: 106
Joined: Mar 2010
(2013-12-22, 00:35:10)shawn_a Wrote: I also added in some new page filters for dynamic slugs testing, to be finalized in rc1. So see if they are useful.
Should enable any custom slug content or rewriting anything one could want to do.
These new filters open new possibilities for developers. Plugins will be able to
- use a slug without requiring the user to create the page
- use special fancy URL structures without requiring the user to edit the default .htaccess file (e.g. multilanguage, item/blog plugins...)