Thanks for providing Get Simple Community Edition and also for Plugin Fixes.
We have noticed following Error Message in i18n_navigation Plugin [after applying Fixes]:
[16-Oct-2022 18:29:06 Asia/Kolkata] PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_navigation/editextras.php on line 11
PHP Code:
foreach (preg_split('/\s*,\s*/', trim(@$page['tags'])) as $t) $tags[$t] = true;
We are also noticing following Error Messages in other Plugins:
[16-Oct-2022 18:20:51 Asia/Kolkata] PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searchform.php on line 80
[16-Oct-2022 18:27:19 Asia/Kolkata] PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searcher.class.php on line 261
[16-Oct-2022 18:27:19 Asia/Kolkata] PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searcher.class.php on line 264
PHP Code:
$order = trim($order);
[16-Oct-2022 18:21:15 Asia/Kolkata] PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/xxxx/public_html/plugins/pagify.php on line 96
PHP Code:
if (!preg_match('/^hr|(\d+)\s*([a-zA-Z]*)$/',$pageSize,$match)) return $content;
Thanks for providing Get Simple Community Edition and also for Plugin Fixes.
We have noticed following Error Message in i18n_navigation Plugin [after applying Fixes]:
[16-Oct-2022 18:29:06 Asia/Kolkata] PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_navigation/editextras.php on line 11
PHP Code:
foreach (preg_split('/\s*,\s*/', trim(@$page['tags'])) as $t) $tags[$t] = true;
We are also noticing following Error Messages in other Plugins:
[16-Oct-2022 18:20:51 Asia/Kolkata] PHP Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searchform.php on line 80
[16-Oct-2022 18:27:19 Asia/Kolkata] PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searcher.class.php on line 261
[16-Oct-2022 18:27:19 Asia/Kolkata] PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searcher.class.php on line 264
PHP Code:
$order = trim($order);
[16-Oct-2022 18:21:15 Asia/Kolkata] PHP Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/xxxx/public_html/plugins/pagify.php on line 96
PHP Code:
if (!preg_match('/^hr|(\d+)\s*([a-zA-Z]*)$/',$pageSize,$match)) return $content;
Please guide us in this regard.
Thanks,
What version php you test it? I test only i18n - soon i i18n search and rest i18n support. Maybe this is why you saw error.
2022-10-17, 11:17:35 (This post was last modified: 2022-10-23, 00:03:43 by celextel.)
(2022-10-17, 06:16:30)multicolor Wrote: What version php you test it? I test only i18n - soon i i18n search and rest i18n support. Maybe this is why you saw error.
PHP Version: 8.1.9
We have just noticed another Error Log Message in regard to i18n_navigation Plugin [after applying Fixes]:
[17-Oct-2022 12:39:54 Asia/Kolkata] PHP Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; I18nNavigationItem has a deprecated constructor in /home/XXXX/public_html/plugins/i18n_navigation/frontend.class.php on line 349
It would be nice to have a patch repo, for patching plugins, without hosting actual code as we have no idea what the various licenses are. So like a patcher script but that would be hard without versioning
(2022-10-27, 06:03:18)shawn_a Wrote: It would be nice to have a patch repo, for patching plugins, without hosting actual code as we have no idea what the various licenses are. So like a patcher script but that would be hard without versioning
Look what people search, version patched ready to use - no patched files. For some user replace file to another on plugin is to difficult. Now we try something like this, we try help community no theft something. I hope authors leaved project understand this.
I am working on a setting up a dev enviroment for this using rector to auto migrate the entire repo.
Not sure if it will work on proceedural code without classes, i have never used it before.
If you are a php developer please hit me up on the discord
2022-11-01, 09:24:51 (This post was last modified: 2022-11-01, 11:10:57 by vanfruniken.)
(2022-10-28, 02:22:53)shawn_a Wrote: I need plugins to fix, give me examples
Hi Shawn,
I'd like to report warnings on php7.4 for plugins
1. sa_toc_anchors.php, which makes use of create_function(...,...)
This function internally used eval() and was considered a security risk, while also being global, scopeless, not garbage collectable, ... . Under php7 I get a warning and under php8 a fatal error: Fatal error: Uncaught Error: Call to undefined function create_function() in /.../plugins/sa_toc_anchors.php:45 Any suggestions for replacement code?
2. (already fixed in repo) plugins/i18n_navigation/frontend.class.php: old style constructor near 350
3. plugins/sa_hook_components:74 eval'd code on l64, use of undefined constant trim
4. plugins/i18n_base/frontend.class.php(127) : eval()'d code on line 21
Hopefully my site will run fine as soon as the above are fixed.
FYI, I use the following plugins on my site:
Cookies Plugin by Cumbe
FAQ by Vlcek
GSMaintenance
GSPlugin Installer by Helge Sverre
GS_Shortcodes by Mike Swan
HitCount
I18NBase
I18N
I18Search
ItemManager
SA_hook Components
SA_toc_anchors
Theme Highlighter
Multi User by Mike Henken
p.s. I am thrilled that GS is again moving ahead with more people stepping in to help out. Will your plugin repository also include updated versions?
BTW, I read that php 8 will also only have a short life. My hosting already kills php 7.x on Nov 1, '22; something similar will happen next year, I am afraid. How long before php (and its function library) can evolve without further code-breaking changes?