optional parameters of "component"

[Zegnåt]

BTW: a return after the eval would be beneficial

What kind of return would you suggest?

I just meant a return directly after the eval.

I guess this would be better performance wise, I just don’t like returns inside loops. Maybe put a break there instead.

But as you mention it, in the I18N plugin I return, if the component exists or not

I have one issues with your code as it stands: it doesn’t return whether the component actually works or not. eval() is no magic and the PHP inside might fail. My proposed return is this: (Where $eval holds the return value of eval().)

Code:

$eval===NULL||$eval!==FALSE;

Any eval() that just runs code will return NULL on success, it will return FALSE if it encounters a PHP error or it might return any arbitrary value if someone used “return”. The above code will return TRUE if the component has produced a non-FALSE response.

Let me know what you think of that.

Combining:

Code:

function get_component($id) {
    global $components;
    if (func_num_args() > 1) { $args = func_get_args(); array_shift($args); }
    if (!$components) {
         if (file_exists(GSDATAOTHERPATH.'components.xml')) {
            $data = getXML(GSDATAOTHERPATH.'components.xml');
            $components = $data->item;
        } else {
            $components = array();
        }
    }
    if (count($components) > 0) {
        foreach ($components as $component) {
            if ($id == $component->slug) {
                $eval = eval("?>" . strip_decode($component->value) . "<?php ");
                break;
            }
        }
    }
    return $eval===NULL||$eval!==FALSE;
}

If you can agree with this as a solution I could put it in the core right now.