Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Bug: htmlentities messes code blocks
#1
Greek characters are unicode supported. If entered as regulart text, they make no difference than other text.
If entered in a <code> block they are presented with their entity form. This results to
Code:
&pi; = 3.14
&phi; = 1.62

instead of

Code:
π = 3.14
φ = 1.62

The problem lies into safe_slash_html() function inside admin/inc/basic.php where htmlentities is used. htmlentities() and htmlspecialcharacters() are identical in all ways, except with htmlentities(), all characters which have HTML character entity equivalents are translated into these entities.

Fix:

FIND
Code:
function safe_slash_html($text) {
    if (get_magic_quotes_gpc()==0) {
        $text = addslashes(htmlentities($text, ENT_QUOTES, 'UTF-8'));
    } else {
        $text = htmlentities($text, ENT_QUOTES, 'UTF-8');
    }
    return $text;
}

REPLACE, WITH
Code:
function safe_slash_html($text) {
    if (get_magic_quotes_gpc()==0) {
        $text = addslashes(htmlspecialchars($text, ENT_QUOTES, 'UTF-8'));
    } else {
        $text = htmlspecialchars($text, ENT_QUOTES, 'UTF-8');
    }
    return $text;
}
Reply


Messages In This Thread
Bug: htmlentities messes code blocks - by intelx86 - 2012-02-05, 01:56:45
Bug: htmlentities messes code blocks - by Connie - 2012-02-05, 04:35:39
Bug: htmlentities messes code blocks - by Connie - 2012-02-06, 17:08:08
Bug: htmlentities messes code blocks - by Carlos - 2012-02-07, 04:11:58
Bug: htmlentities messes code blocks - by Carlos - 2012-02-07, 04:29:05
Bug: htmlentities messes code blocks - by Carlos - 2012-02-07, 05:35:21



Users browsing this thread: 1 Guest(s)