Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Patch with suggestion for hard coded accelerator keys problem
#1
I created an issue to attach a patch that tries to address the problem of accelerator keys missing in translations, as I explained here http://get-simple.info/forum/topic/1146/...slations/.

I took the simple path of creating a function that receives the string, finds the letter between the <em> tags using a regex expression and returns that letter in lowercase.

The issue is http://code.google.com/p/get-simple-cms/...tail?id=83 and has the patch file attached.
Rejoice! For very bad things are about to happen.
Reply
#2
great, thanks! I dont have time to look at it now, or probably even this week, but i promise i or someone else will look at it. Thanks for your contribution!!
- Chris
Thanks for using GetSimple! - Download

Please do not email me directly for help regarding GetSimple. Please post all your questions/problems in the forum!
Reply
#3
Well, it's suggestion, if you find it a valid change and it helps then we all gain something Smile

I do advise that the person who reviews the code gives some attention the the changes in interface files as I had made several changes, and last nights svn update created many conflicts and, though I tested the patch and reviewed it, I may have missed a change that should not be there.
Rejoice! For very bad things are about to happen.
Reply




Users browsing this thread: 1 Guest(s)