[SOLVED] GS 3.1 beta - encoding issues

[Carlos]

EDIT: This has been fixed in r650
---------------

GS 3.1 beta has some encoding problems in the header's meta description and keywords. Example:

Code:

á ä

is encoded as (look at the page's source code):

Code:

á ä

instead of:

Code:

á ä

I've suggested this patch to the encode_quotes() function:

Edit admin/inc/basic.php, line 471,
Replace:

Code:

$text = htmlspecialchars($text, ENT_QUOTES);

by:

Code:

$text = htmlspecialchars($text, ENT_QUOTES, 'UTF-8', false);

This works for me, tested with the latest r646 featured beta.
Could you please test this?

[Carlos]

Another encoding issue that is still happening (we discussed in other threads but hasn't been fixed), this one with the menu (generated by get_navigation()). Problems with backslashes, double quotes...

I suggest you try this fix:
Edit admin/inc/theme_functions.php, line 613. Replace:

Code:

$menu .= '<li class="'. $classes .'"><a href="'. find_url($page['url'],$page['parent']) . '" title="'. $page['title'] .'">'.$page['menu'].'</a></li>'."\n";

by:

Code:

$menu .= '<li class="'. $classes .'"><a href="'. find_url($page['url'],$page['parent']) . '" title="'. encode_quotes(cl($page['title'])) .'">'.strip_decode($page['menu']).'</a></li>'."\n";

(What we've done here is changing $page['title'] to encode_quotes(cl($page['title'])) and $page['menu'] to strip_decode($page['menu']))

Note that you also have to do my previous suggested patch (to basic.php)

Please people test and tell me if it works for you...

[n00dles101]

I've commited these to the SVN, hopefully thats the end of the encoding issues.
Also fixes the error reporting problem you reported n teh issue tracker...

Thanks Carlos...