Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Release 3.3.0 Beta
#51
(2013-11-02, 19:12:38)Kolyok Wrote: It could be related to this(?)

Issue: https://github.com/GetSimpleCMS/GetSimpleCMS/issues/674

Ah yes, of course.
Reply
#52
(2013-11-02, 19:12:38)Kolyok Wrote: It could be related to this(?)

Yes, that's it. In my defence, I searched the whole of get-simple.info and I thought I had searched the github repository (surely the most cryptic site on the Internet ;-) ).

It might be useful to add Issue #674 to the Beta changelog ...

Great support, as always – thanks.
--
Nick.
Reply
#53
oh wow , sorry about that.
I will fix that up later when I release b3.

For some reason our gs install is always cached and i always wind up losing edits and resaving old stuff.
I have no idea why this is, I created this issue but i only ever see this on our gs install. It never happened on my host.

https://github.com/GetSimpleCMS/GetSimpl...4?source=c
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#54
for sitemap and cache save I have 2 hooks
sitemap-saved
pagecache-saved

now these are not consistently named, since saved means it saved, but it might not.

I am changing them to aftersave hooks.

And if we need some success and fail detection in the future we can add that later.

This is also consistent with changedata hooks, so i think I will just go ahead and change it. but would love to hear any arguments before I merge it into b3 later today.

develop branch has some pagecache fixes and lazy loading, and these changes I mentioned.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#55
Beta 3 released

significant changes from beta 2

Fixed up page caching even more, reduced file loads, and file checks, fixed some mutiple save issues.
Added lazy loading for page cache functions -carlos
Critical api offline fix
changed sitemap and pagecache hooks ( sorry )
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#56
pages.xml is now loaded only once in frontend - nice.

Quick tests (I have to play a bit more):

- Fresh installation in local XAMPP server. No mail server enabled. I go to SITE/admin (root doesnt work), I enter website name, username and email and click Install Now. I get this:
Quote:Error: There was a problem sending out the registration information via email. Please make note of the password below.
Your username is ***** and your password is ******
» Login here
Ok, but below that, again I see the installation start screen, like it hadn't been installed.

- Upgrade install over 3.2.3. I create/edit a page, click on "ckeditor Insert/edit link" icon, screen goes dark and no popup appears.
(Maybe it's a conflict with a plugin or something, I have to check further...)
Reply
#57
known issue if mail fails
https://github.com/GetSimpleCMS/GetSimpleCMS/issues/686

cke sounds like a cache issue
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#58
(2013-11-04, 05:25:57)shawn_a Wrote: known issue if mail fails
https://github.com/GetSimpleCMS/GetSimpleCMS/issues/686

Ah ok, hadn't seen that.

(2013-11-04, 05:25:57)shawn_a Wrote: cke sounds like a cache issue

Sorry, my fault - a patch I did for testing and forgot to undo.
Reply
#59
Until 3.2.x it was easy -for webmasters and plugins- to remove the "Link to local page" link type from the ckeditor dropdown:
http://get-simple.info/forums/showthread...9#pid19849

In 3.3.0 beta ckeditor_add_page_link() is deprecated and of course the trick doesn't work.

What would be the way to remove it, or even better, would it be possible to change the order so that "URL" is shown first, as default?

(BTW in the following posts in the thread above we commented some more things about this...)
Reply
#60
Yeah I tried making a popup browser, but there was a critical bug in our ck version preventing it.

You can customize this yourself in 3.3 in your config.js.
You can remove the entire code for the dialogoverride, or set menuItems array however you want.

It might be good to have an option to disable, or a filter like i said as well.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#61
I just added some commenting to the config.js in `develop` and fixed it up so it wont choke on an empty menuItems var, if its empty it won't add the localpage select anymore.

If you plan on creating a custom ckeconfig be sure to read
https://github.com/GetSimpleCMS/GetSimpl...t-27887257

If you want to keep localpages but force url to be default, change this to "url"
Code:
//config.js
data.type = 'localPage'; // default to localPage
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#62
Added issue for link local menu customization.
https://github.com/GetSimpleCMS/GetSimpleCMS/issues/692

Could this be fixed via permalink though ?
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#63
@shawn_a

Thank you for your suggestions. I have to take a closer look at how this ckeditor stuff works...

What's the menuItems var you mentioned?

(2013-11-07, 02:31:34)shawn_a Wrote: Could this be fixed via permalink though ?

Sorry, I don't get it.
Reply
#64
It's just a json array that ckeditor link plugin uses, but I was wondering why we would need to customize it when it could be fixed by getting proper values from permalink.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#65
Have any bugs come up or anything that must make into this release?
Going to cut rc1 soon.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#66
There's (at least) one issue with the I18N plugin.
Ckeditor "link to local page" dropdown was (until 3.2.3) customized by this plugin, filtering slugs by language (based on the edited page's one).
With 3.3.0 beta you get the default GS dropdown (with all slugs, e.g. index, index_en, ...)
Reply
#67
How was it customized? , I thought the whole issue of the previous posts was that it does not.
Probably some pages sorted global that I removed.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#68
Which i18n plugin does this specifically?
I see custom functions in specialpages and customfields, but i do not think either of those change the list.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#69
I18N. I think it's in i18n_navigation/editorinit.php
See it uses ⌊ as prefix for subpages instead of a dash (as GS)
Reply
#70
So strange, I have v3.2.5, and didn't have this file.
I had to redownload it.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#71
The new dialog definition callback now occurs after that one, since it is processed in order i guess, or because config.js is loaded asynchronously.

Not sure how to fix it, without breaking the plugin feature. Ill sleep on it.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#72
The kewl thing i noticed is you can keep adding selects, so you could even have multiple selects one for i18n or perhaps even one to solve our other problem of relative links.

This should probably have been done after instanceready event.
Unless I changed that, I believe the html-edit-init was always between 2 script tags.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#73
We should really consider adding our own cke events for things we do like this.
the hook html-editor-init is deceiving also.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#74
i18n issue fixed in develop, thanks carlos!
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#75
You're welcome. Tested, works ok. Great!
Reply




Users browsing this thread: 1 Guest(s)
Free HDTV Channels Residential Solar Panels