Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Release 3.3.0 Beta
#76
Shawn,
Related to this:
http://get-simple.info/forums/showthread...7#pid40697

I've experimented a bit. If you remove this from caching_functions.php:
Code:
add_action('header', 'getPagesXmlValues',array(true));   // make $pagesArray available to the back

and add this to get_available_pages (line 627) and list_pages_json (line 749):
Code:
getPagesXmlValues();

then pages.xml is loaded only once in pages.php, edit.php, menu-manager.php, and never in other backend pages (that don't need it).
I think that this doesn't break anything.
Reply
#77
It is already loaded only once, unless a plugin lazy loads it before the header hook , where are you seeing that this still a problem?
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#78
caching_functions.php
Code:
function getPagesXmlValues($chkcount=false){
...
    $data = simplexml_load_string($thisfile);
    debugLog('pages.xml read'); // ADDED FOR TESTING

I see it's loaded twice in Pages, Edit and Menu-manager.
Once in the rest of admin pages.
Reply
#79
Not sure how, you totally skipped the existing return check I that code snippet.
Something could be nullifying your pages array global?
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#80
Hmm you are probably right, I think I forgot to remove that hook.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#81
I like the beta. Not really noticeable differences than release but it works well.
Reply
#82
carlos I have no idea how you are having this issue. This was fixed like a month ago, and should have not been an issue in b3.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#83
I checked again with fresh installs.
Code:
$thisfile = file_get_contents($file);
debugLog('pages.xml read'); // TESTING
(caching_functions.php)

pages.xml loaded twice in Page manager and Menu-manager.
Once in the other admin pages.

(I said twice in Edit/create page, but it's once, sorry)
Reply
#84
Not on default install, you using nm?
I have tested this with 28 plugins.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#85
Fresh install with no plugins (even default ones disabled). Tested with 3.3.0b3 and develop version.
Debug Console:
Quote:pages.xml read
pages.xml read
on admin/pages.php and admin/menu-manager.php
Reply
#86
See it now, thanks.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#87
ok this is probably fixed in develop now
Thanks carlos

I was not seeing this issue cause I was testing i18n still and had it running its own "pages.php"
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#88
Beta 4 released

Beta extended to one more test, some last minutes stuff made it in namely ckeditor 3.6.6 to fix IE10 fatal issues.

I also added in some new page filters for dynamic slugs testing, to be finalized in rc1. So see if they are useful.
Should enable any custom slug content or rewriting anything one could want to do.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#89
(2013-12-22, 00:35:10)shawn_a Wrote: I also added in some new page filters for dynamic slugs testing, to be finalized in rc1. So see if they are useful.
Should enable any custom slug content or rewriting anything one could want to do.

These new filters open new possibilities for developers. Plugins will be able to
- use a slug without requiring the user to create the page
- use special fancy URL structures without requiring the user to edit the default .htaccess file (e.g. multilanguage, item/blog plugins...)
Reply




Users browsing this thread: 1 Guest(s)
Free HDTV Channels Residential Solar Panels