Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
BETA 3.3.9 beta 3
#26
Yeah I figured that , i thought maybe it would store as the same asset but pull as a new one forcing the cache to update. We could use a blind rewrite for a folder bersion request. Plugins are always gonna have a problem but technically most people will only have this problem if the auto cache is recently accessed since it uses etag and lastmodified
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#27
I forgot i gotta finalize these cache issues and changes before i release this, oops, ill get that done and release 3.3.9 soon. Sorry for the delay been busy.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#28
I committed a ajax fetch to see if it makes any difference
I doubt it but last try.

https://github.com/GetSimpleCMS/GetSimpl...ee/v3.3.9b
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#29
Just tested (with Chrome, with Firefox, XAMPP, shared host) and no difference - same issue.

So, as I said in my previous post, I think it may be better to leave it as it was in beta 1, and warn in the changelog about these potential ckeditor cache issues.
Reply
#30
Yeah serms like the only fix is to rename theme which breaks plugins or modify ckeditor ourselves.
Oh well , ill revert these and jist leave it alone and tinestanp stuff later when there is a solution
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#31
Hello Mr Shawn, first of all, a big thx for all this beautiful work with GS.

I'm coming here after discussion with Datiswous and jwzumwalt :
(http://get-simple.info/forums/showthread.php?tid=8352)

After testing the Beta, my issue have gone !
Thanks again Big Grin

Now, could you please tell me (approximately), when Stable Release is ready ?

Best regards from France.
OF
Reply
#32
Merged into stable. You will probably need to hard refresh.
Does anyone wanna QA this before I post the release ?

https://github.com/GetSimpleCMS/GetSimpl...tag/v3.3.9

I also added the / thingy commented in the config.js
// ev.editor.dataProcessor.writer.selfClosingEnd = '>'; // self closing defautls to />
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#33
(2016-04-20, 03:16:33)shawn_a Wrote: Merged into stable. You will probably need to hard refresh.
Does anyone wanna QA this before I post the release ?

https://github.com/GetSimpleCMS/GetSimpl...tag/v3.3.9

I also added the / thingy commented in the config.js
   // ev.editor.dataProcessor.writer.selfClosingEnd = '>'; // self closing defautls to />

Ah ok so if you want <br> for example you have to remove the // before this line.

I tested this version on localhost and online. Upgrade and new install worked fine, never needed a hard refresh.

It still says 3.3.9  Beta / Bleeding Edge in Website health check
Reply
#34
thanks for the new editor and plugin codesnippet
Reply
#35
I wonder if this single change would fix the icons caching

ckeditor.js
2016,auto','icons.png');}) <-- add querystring to filename

If anyone wants to try It would be good to know, it could just break it, since its js.

It is hard to tell because the css files also reference icons.png as an asset.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#36
I also kept the ckeditor timestamp code but moved it to a optional definition
It will probably be enable at some point in the future or you can do it yourself.

common.php
// if(!defined('GSCKETSTAMP')) define('GSCKETSTAMP',get_gs_version()); // ckeditor asset querystring for cache control
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#37
Has any thought been given to adapting this parent menu driven page navigation to the core?
I and others have over 200 pages and it gets out of control.

http://get-simple.info/forums/showthread.php?tid=8353
Thanks,
jwzumwalt
(\__/)
(='.'=)
(")_(")
Reply
#38
(2016-04-20, 03:16:33)shawn_a Wrote: Merged into stable. You will probably need to hard refresh.
Does anyone wanna QA this before I post the release ?

https://github.com/GetSimpleCMS/GetSimpl...tag/v3.3.9

I also added the / thingy commented in the config.js
   // ev.editor.dataProcessor.writer.selfClosingEnd = '>'; // self closing defautls to />

So, is the "stable" 3.3.9 update procedure simply overwrite existing files, or is there more to do?
Also, what is the difference between 3.3.9 and .10?
Thanks,
jwzumwalt
(\__/)
(='.'=)
(")_(")
Reply
#39
(2016-04-21, 01:33:44)jwzumwalt Wrote: Has any thought been given to adapting this parent menu driven page navigation to the core?
I and others have over 200 pages and it gets out of control.

http://get-simple.info/forums/showthread.php?tid=8353

Btw. you can already do the same with the i18N plugin.

jwzumwalt Wrote:So, is the "stable" 3.3.9 update procedure simply overwrite existing files, or is there more to do?
Also, what is the difference between 3.3.9 and .10?
http://get-simple.info/wiki/installation:upgrade   I remove the admin folder and index.php on my website and copy these over from the new release.
Reply
#40
(2016-04-21, 00:56:53)shawn_a Wrote: I wonder if this single change would fix the icons caching

ckeditor.js
2016,auto','icons.png');}) <-- add querystring to filename

If anyone wants to try It would be good to know, it could just break it, since its js.

It is hard to tell because the css files also reference icons.png as an asset.

I changed 'icons.png' to 'icons.png?t=something' - doesn't break but no effect, same issue (until I Ctrl-F5 on Firefox / clear browsing data in Chrome)
Reply
#41
Yeah I guess the css is causing the actual asset load, which means you have to change every instance in all the css for the theme, I guess the best solution will be to add a cache policy.


The codesnippet plugin uses highlight.js ( it can be modified to use alternates as well and geshi )
if you want to add front end to your theme you can play with this., and there are a bunch of themes in the folder.

PHP Code:
<?php
GLOBAL $SITEURL;
GLOBAL 
$GSADMIN;
?>
<link rel="stylesheet" href="<?php echo $SITEURL.$GSADMIN;?>/template/js/ckeditor/plugins/codesnippet/lib/highlight/styles/monokai_sublime.css" rel="stylesheet">
<script src="<?php echo $SITEURL.$GSADMIN;?>/template/js/ckeditor/plugins/codesnippet/lib/highlight/highlight.pack.js"></script>
<script>hljs.initHighlightingOnLoad();</script> 

You will have to reset or remove any aggressive pre and code css though.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#42
(2016-04-21, 01:44:26)datiswous Wrote:
(2016-04-21, 01:33:44)jwzumwalt Wrote: Has any thought been given to adapting this parent menu driven page navigation to the core?
I and others have over 200 pages and it gets out of control.

http://get-simple.info/forums/showthread.php?tid=8353

Btw. you can already do the same with the i18N plugin.
Not really, you can not collapse a "parent", so you are left with a 200+ listing.
So I guess we can say it sorts the pages but does not really do much else.
Thanks,
jwzumwalt
(\__/)
(='.'=)
(")_(")
Reply
#43
(2016-04-21, 11:37:42)jwzumwalt Wrote:
(2016-04-21, 01:44:26)datiswous Wrote:
(2016-04-21, 01:33:44)jwzumwalt Wrote: Has any thought been given to adapting this parent menu driven page navigation to the core?
I and others have over 200 pages and it gets out of control.

http://get-simple.info/forums/showthread.php?tid=8353

Btw. you can already do the same with the i18N plugin.
Not really, you can not collapse a "parent", so you are left with a 200+ listing.
So I guess we can say it sorts the pages but does not really do much else.
Sorry, I thought I understood what is described on that page, apparently I didn't..

I thought 200+ parents in view is a little unrealistic.
Reply
#44
Hello Shawn,

Have you ever seen a Bug like this ? please see attached img

I've upgraded from 3.3.8 to the last stable 339.
Tried to clear cache. Tried to change editorOptions also.
Still the problem.

I really don't get the point here.

What could be the cause ?


Attached Files Thumbnail(s)
   
Reply
#45
Cache problem, icons.png is old. Or you have a custom theme set.
Login as provate browsing mode and see, you probably didnt really clear your browserr cache.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#46
(2016-04-27, 08:45:41)shawn_a Wrote: Cache problem, icons.png is old. Or you have a custom theme set.
Login as provate browsing mode and see, you probably didnt really clear your browserr cache.

This is good now. What about this CKeditor feature :

http://ckeditor.com/demo#inline

Do you think this is an easy integration ?

Thanks for your time.
Reply
#47
I have discussed it elsewhere, but its doable, but there are thinggs that need clever solutions, like switching the content in and out, so you are actually editing the source before any filtering and component expansion., so there needs to be some js fetching and swapping.
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#48
For the moment, we have to keep things... simple.
One more thing, i noticed a little problem (for me at least)

- Copy to clipboard doesn't duplicate everything easily, for example :

We make a table with a certain pattern inside. Like an "editable grid".
The user change img, link etc. As he needs to.

But if (s)he wants to duplicate on the same page, the exact same pattern, it has to be done by "source" way.

Do this "copy-to-clipboard" can be enhanced ?
Reply
#49
Are you sure its not paste thats the problem. Are you isong plaintext paste?
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#50
(2016-04-27, 21:54:44)shawn_a Wrote: Are you sure its not paste thats the problem. Are you isong plaintext paste?

Well, to give an example, i have an img and a paragraph in a cell.

i select the cell content (getting blue).

I hit the ctrl+c, then in a new cell, hit the ctrl+v.

Image disappears. Text is ok.

How can i do ?

thx
Reply




Users browsing this thread: 1 Guest(s)