GetSimple Support Forum
Patch with suggestion for hard coded accelerator keys problem - Printable Version

+- GetSimple Support Forum (http://get-simple.info/forums)
+-- Forum: GetSimple (http://get-simple.info/forums/forumdisplay.php?fid=3)
+--- Forum: Developer Discussions (http://get-simple.info/forums/forumdisplay.php?fid=8)
+--- Thread: Patch with suggestion for hard coded accelerator keys problem (/showthread.php?tid=1091)



Patch with suggestion for hard coded accelerator keys problem - Knitter - 2010-11-02

I created an issue to attach a patch that tries to address the problem of accelerator keys missing in translations, as I explained here http://get-simple.info/forum/topic/1146/how-to-proceed-when-accesskey-isnt-preserved-in-translations/.

I took the simple path of creating a function that receives the string, finds the letter between the <em> tags using a regex expression and returns that letter in lowercase.

The issue is http://code.google.com/p/get-simple-cms/issues/detail?id=83 and has the patch file attached.


Patch with suggestion for hard coded accelerator keys problem - ccagle8 - 2010-11-03

great, thanks! I dont have time to look at it now, or probably even this week, but i promise i or someone else will look at it. Thanks for your contribution!!


Patch with suggestion for hard coded accelerator keys problem - Knitter - 2010-11-03

Well, it's suggestion, if you find it a valid change and it helps then we all gain something Smile

I do advise that the person who reviews the code gives some attention the the changes in interface files as I had made several changes, and last nights svn update created many conflicts and, though I tested the patch and reviewed it, I may have missed a change that should not be there.