studiosi Wrote:In function show_blog_navigation, why is the right arrow inside this if?

if ($index < $total && $count >= $Blog->getSettingsData("postperpage")) { ... }

I'm missing something?

thanks everybody,

studiosi Wrote:I have a solution for both problems. It was because of a faulty design of a couple of functions in the core. Please Mikeh, add this to the main distribution so others don't have to scratch their heads like me . Here's the code of both functions I had to modify. I want to thankyou of course for this plugin!:

// show_posts_page

function show_posts_page($index=0)
{
$Blog = new Blog;
$posts = $Blog->listPosts(true, true);
if($Blog->getSettingsData("allpostsadtop") == 'Y')
{
?>
<div class="blog_all_posts_ad">
<?php echo $Blog->getSettingsData("addata"); ?>
</div>
<?php
}
if(!empty($posts))
{
$pages = array_chunk($posts, intval($Blog->getSettingsData("postperpage")), TRUE);
if (is_numeric($index) && $index >= 0 && $index < sizeof($pages))
{
$posts = $pages[$index];
}
else
{
$posts = array();
}
$count = 0;
$lastPostOfPage = false;
foreach ($posts as $file)
{
$count++;
show_blog_post($file['filename'], true);

if($count == sizeof($posts) && sizeof($posts) > 0)
{
$lastPostOfPage = true;
}

if (sizeof($pages) > 1)
{
// We know here that we have more than one page.
$maxPageIndex = sizeof($pages) - 1;
show_blog_navigation($index, $maxPageIndex, $count, $lastPostOfPage);
if($count == $Blog->getSettingsData("postsperpage"))
{
$count = 0;
}
}
}
}
else
{
echo '<p>' . i18n(BLOGFILE.'/NO_POSTS') . '</p>';
}
if($Blog->getSettingsData("allpostsadbottom") == 'Y')
{
?>
<div class="blog_all_posts_ad">
<?php echo $Blog->getSettingsData("addata"); ?>
</div>
<?php
}
}

// show_blog_navigation
function show_blog_navigation($index, $total, $count, $lastPostOfPage)
{

$Blog = new Blog;
$url = $Blog->get_blog_url('page');

if ($lastPostOfPage)
{
echo '<div class="blog_page_navigation">';
}

echo $needsNavigationDiv;

//if ($index < $total && $count >= $Blog->getSettingsData("postperpage"))
if($index < $total && $lastPostOfPage)
{
?>
<div class="left">
<a href="<?php echo $url . ($index+1); ?>">
&larr; <?php echo $Blog->getSettingsData("previouspage"); ?>
</a>
</div>
<?php
}
?>

<?php
//if ($index > 0 && $count >= $Blog->getSettingsData("postperpage"))
if ($index > 0 && $lastPostOfPage)
{
?>
<div class="right">
<a href="<?php echo ($index > 1) ? $url . ($index-1) : substr($url, 0, -6); ?>">
<?php echo $Blog->getSettingsData("nextpage"); ?> &rarr;
</a>
</div>
<?php
}
?>

<?php
if ($lastPostOfPage)
{
echo '</div>';
}

}

studiosi Wrote:Of course... I will upload it as soon as i get to know how that works...

• Incredibly simple to set up (principle philosophy of GS!) - it actually shocked me how easily features were to enable
  
• Good integration of external comments system Disqus among other features
  
• Decent degree of customisation for early stages
  
• Lots of potential, especially with the possibility of custom-fields in the next iteration 1.2
  

• The pretty url system needs to be pretty solid when it is complete, especially regarding the Disqus comments system. If it doesn't treat the separate news articles separately enough in their URL location then the commenting system could face some ugly problems in the long run with comments running into the wrong article(s)
  
• Databases - if you are going to do this, please consider n00dle's Matrix plugin which uses an XML database instead (but provides all of the features of a MySQL database; all within the confines of the GS admin panel!). One considerable appeal of GS is its flatfile nature, so it'd be good if the (potentially) most complete blogging system of GS conformed to that ideal
  
• May want to proof-read a few pages - under 'Post Option' on the post's creation page for example, the label 'Slug/URL' can be seen where it should say 'Creation Date', and on the same page 'separate' has been spelt with two 'a's - cleaning up minor mistakes like these will just make it look more professional
  
• This may be an inevitability with the coming of custom-fields, but just to be sure: will there be a 'template' feature wherein the output/css of the blog can be configured to the user's liking?
  
• I don't think that placeholders work - so any content that users previously had within (% %) tags will not be viewed correctly.
  

Dominic Wrote:Hi Mike,

I am poking around GS Blog and love it so far and can see that and your Items Manager becoming my essential web site tools!

I do have 2 questions:

1: The Previous Blog Post and Next Blog Post links are not showing up. Is there a known issue with that? I couldn't find it in the forum.

2: When is version 1.2 with the custom fields coming out??? I am really looking forward to that!

Thanks again for all your contributions to the GS community.
-Dominic

P.S. I agree with AngryBoy's wish in the previous post that you stick with a purely XML database. The only reason I am on Get Simple is to avoid MySql. If you start using that, I might as well just go back to wordpress!

• Fixed Pretty URL bug Pretty URLs are now working!
  
• Fixed some bugs in relation to "Previous Blog Post" & "Next Blog Post" links
  
• Added text area and checkbox in settings page to display CSS. Also added list of available ids and classes and an example of the html behind a post.
  
• Added a few more css classes to elements
  
• Fixed labels
  

Angryboy Wrote:Took a while for me to get out of my settled ways with I18N Special Pages and try this thing out properly. Surprised to see that it is doing most of the right things and ticking the right boxes, so very good stuff mikeh :-)

Ups

• Incredibly simple to set up (principle philosophy of GS!) - it actually shocked me how easily features were to enable
  
• Good integration of external comments system Disqus among other features
  
• Decent degree of customisation for early stages
  
• Lots of potential, especially with the possibility of custom-fields in the next iteration 1.2
  

Downs / areas to improve/be careful of...

• The pretty url system needs to be pretty solid when it is complete, especially regarding the Disqus comments system. If it doesn't treat the separate news articles separately enough in their URL location then the commenting system could face some ugly problems in the long run with comments running into the wrong article(s)
  
• Databases - if you are going to do this, please consider n00dle's Matrix plugin which uses an XML database instead (but provides all of the features of a MySQL database; all within the confines of the GS admin panel!). One considerable appeal of GS is its flatfile nature, so it'd be good if the (potentially) most complete blogging system of GS conformed to that ideal
  
• May want to proof-read a few pages - under 'Post Option' on the post's creation page for example, the label 'Slug/URL' can be seen where it should say 'Creation Date', and on the same page 'separate' has been spelt with two 'a's - cleaning up minor mistakes like these will just make it look more professional
  
• This may be an inevitability with the coming of custom-fields, but just to be sure: will there be a 'template' feature wherein the output/css of the blog can be configured to the user's liking?
  
• I don't think that placeholders work - so any content that users previously had within (% %) tags will not be viewed correctly.
  

Don't let this list get in the way of the pieces you are already tackling. You're doing an awesome and very appreciated job already mikeh, so I hope this completed module receives its accolades. :-)

studiosi Wrote:I did a fork at github to solve some problems with the links... i don't know if the pull request is done, but... check it in my fork if it is not integrated. Check the generated HTML and tweak blog.php if needed... i think that a template system would be a great add on to this project... which is really good work anyways...

mikeh Wrote:

studiosi Wrote:I did a fork at github to solve some problems with the links... i don't know if the pull request is done, but... check it in my fork if it is not integrated. Check the generated HTML and tweak blog.php if needed... i think that a template system would be a great add on to this project... which is really good work anyways...

I have incorporated your changes into version 1.1.4. Thank you for your contribution.

shawn_a Wrote:

mikeh Wrote:

studiosi Wrote:I did a fork at github to solve some problems with the links... i don't know if the pull request is done, but... check it in my fork if it is not integrated. Check the generated HTML and tweak blog.php if needed... i think that a template system would be a great add on to this project... which is really good work anyways...

I have incorporated your changes into version 1.1.4. Thank you for your contribution.

Does this version have a fix for the content filters issue/pull request I sent you? I haven't checked git lately.

mikeh Wrote:

shawn_a Wrote:

mikeh Wrote:I have incorporated your changes into version 1.1.4. Thank you for your contribution.

Does this version have a fix for the content filters issue/pull request I sent you? I haven't checked git lately.

Yes.

kidata Wrote:Check out the German language file at:

https://github.com/kidata/getsimple-blog/blob/master/blog/lang/de_DE.php

Any improvements welcome.

mikeh Wrote:Thank you for your input. I have incorporated some of your changes into the newest version (pretty urls and label fixes).

In terms of the commenting system. Disqus identifies a blog post by the post's slug. That way it doesn't matter what URL structure the user has or if they change it.

For now I added a text box in the settings panel (as well as on/off switch) to display css for the blog.

• Added field to control how many posts are in RSS feed
  
• Added CDATA to category xml file to fix special characters bug