Getsimple 3.1 Final call for Issues.

[Connie]

for the editor-definitions in edit.php:

I am a little confused by the fact that there are settings for the editor in edit.php plus config.js in \admin\template\js\ckeditor

I think all settings should be set in the config.js (beside those which read the php-constants)
so all settings can be edited by the user and they will not have to edit the core-files

in edit.php:
+ defaultLanguage : 'en', <= that is not necessary
+ entities : true, <= take it to the config.js (in my opinion it is not necessary)

in config.js:

Code:

config.toolbarCanCollapse = false; // hide toolbar collapse button

this setting is wrong, toolbarCanCollapse works!

Code:

config.removePlugins = 'elementspath,resize' ; // hide element path and resizer

this setting is also not so necessary

[Joshas]

in edit.php:
+ defaultLanguage : 'en', <= that is not necessary

I think it is necessary, because if language code will be undefined in translation file - CKeditor will use language file from this setting.

[Connie]

I think it is necessary, because if language code will be undefined in translation file - CKeditor will use language file from this setting.

see here: http://docs.cksource.com/ckeditor_api/sy...#.language

Code:

<static> {String} CKEDITOR.config.language
Since: 3.0
The user interface language localization to use. If left empty, the editor will automatically be localized to the user language. If the user language is not supported, the language specified in the CKEDITOR.config.defaultLanguage configuration setting is used.

and here:
http://docs.cksource.com/ckeditor_api/sy...#.language

Code:

CKEDITOR.config.defaultLanguage
The language to be used if the CKEDITOR.config.language setting is left empty and it is not possible to localize the editor to the user language.

so the last instance for the language is always the user language

that's way this setting is obsolete ;=)