themes editing/viewing permissions

[marrco]

Sometimes i don't allow php writing permissions on the themes directory, and i noticed that a different cms smartly hides the "save changes" button after the editor, while getsimple just gives a "can't open file" error when i try to save changes.
Maybe we should do that too, and hiding the Save Changes button when writing is not possible. And maybe in health check return a warning that modifying themes is disabled.

[shawn_a]

Or just let you turn off the whole thing ?

[datiswous]

Strange enough I was just now (without reading this thread before) thinking about the exact same thing. Weird.

Instead of setting permission for all theme files it can be added as option to gsconfig.php? To make the theme-edit section view-able but disable editing.

[shawn_a]

I suppose I could make it check each files permissions and either hide or disable editing based on that.
I'll have to figure out how that will work in 3.4 as the editor is already written and ajax based.