Posts: 679
Threads: 80
Joined: Nov 2009
Should lines 60 and I believe 73 be converted to i18n when logging users failed login attempts?
On admin/inc/login_functions.php
Posts: 6,266
Threads: 181
Joined: Sep 2011
Not really, its a log file, log files should be standard across systems. Or at least I believe so.
Maybe we can put a code instead and translate it when showing it in the admin.
But the admin uses a generic log viewer, its not specific to failed logins log.
So we would need to make a special log viewer for it, or a universal reason code map.
Posts: 679
Threads: 80
Joined: Nov 2009
In that case maybe we should discuss changing all logs into translatable variables?
I just wanted to open it up to discussion, not a problem just something to think about.
Posts: 6,266
Threads: 181
Joined: Sep 2011
I do not think logs should be multi language that's was my point, logs should be the same always for everyone. But that my view.
Can you give someone your log to read, will they have to translate it or will they all be exactly the same for ease of debugging and reference?
Does apache have different logs in different languages? I don't know.
Posts: 679
Threads: 80
Joined: Nov 2009
2012-11-21, 02:13:40
(This post was last modified: 2012-11-21, 02:13:57 by JWH_Matthew.)
You are making good points. I'm not sure either, I guess it will depend on who we intend the logs to be used for the end user or us..