[SOLVED] Root .htaccess not created when installing (on some servers)

[Carlos]

EDIT: This has been fixed in r640

------

I have tried doing a fresh install of the latest 3.1 beta version (r625) at my webhost and I have a problem: the root .htaccess is not created.
I also tried with r568 and same result. However I don't have this problem with a fresh GS 3.0 install.

It seems it's because of a new check in admin/setup.php (around line 114):

Code:

# create root .htaccess file
        if ( function_exists('apache_get_modules') ) {
            if(in_arrayi('mod_rewrite',apache_get_modules())) {
                ...
            }
        }

(that was introduced by r553, and patched in r554)

My webhost does not have function apache_get_modules(), so next lines inside the if's are not executed.
However my webhost supports mod_rewrite ok.

I have googled about this and it seems that some servers (like mine, I presume) run PHP as a CGI and don't allow to get the list of apache modules. I don't know if this is something usual or not.

To prevent problems like this, but still support servers that don't have mod_rewrite (like issue 258), I suggest you change those two if's by this one (or something similar):

Code:

# create root .htaccess file
        if ( !function_exists('apache_get_modules') or in_arrayi('mod_rewrite',apache_get_modules()) ) {
            ...
        }

EDIT: I've corrected an error in the suggested patch.