2013-04-07, 20:31:59
Hello,
ok, now it is better. The Editor-Windows is visible.
But still troubles if no definitions in gsfonfig.php.
My recommentations are following, because I mean it is more consistent:
DE: Meine Empfehlungen für mehr Konsistenz:
1) If GSEDITOROPTIONS is not defined in gsconfig.php then nothing should be included.
Wenn in gsconfig.php GSEDITOROPTIONS nicht definiert ist, dann sollte auch nichts eingefügt werden.
your GS3.2.1:
my recommentation #1:
2) If GSEDITORTOOL is not defined in gsconfig.php then nothing should be included.
There is a default Toolbar in GKE 4.1 - so I need no config-definition.
DE: Wenn in gsconfig.php GSEDITOROPTIONS nicht definiert ist, dann sollte auch nichts eingefügt werden.
In CKE 4.1 ist sowieso eine Toolbar als default.
your GS3.2.1:
my recommentation #2:
!!! - Changes from Toolbar-Buttons will not recognised !!!
LG Wolfgang
ok, now it is better. The Editor-Windows is visible.
But still troubles if no definitions in gsfonfig.php.
My recommentations are following, because I mean it is more consistent:
DE: Meine Empfehlungen für mehr Konsistenz:
1) If GSEDITOROPTIONS is not defined in gsconfig.php then nothing should be included.
Wenn in gsconfig.php GSEDITOROPTIONS nicht definiert ist, dann sollte auch nichts eingefügt werden.
your GS3.2.1:
Code:
if (defined('GSEDITOROPTIONS') && trim(GSEDITOROPTIONS)!="") { $EDOPTIONS = ", ".GSEDITOROPTIONS; } else { $EDOPTIONS = ''; }
toolbar :
[
<?php echo $toolbar; ?>
]
<?php echo $EDOPTIONS; ?>,
my recommentation #1:
Code:
if (defined('GSEDITOROPTIONS') && trim(GSEDITOROPTIONS)!="") { $EDOPTIONS = GSEDITOROPTIONS.","; } else { $EDOPTIONS = ''; }
toolbar :
[
<?php echo $toolbar; ?>
],
<?php echo $EDOPTIONS; ?>
2) If GSEDITORTOOL is not defined in gsconfig.php then nothing should be included.
There is a default Toolbar in GKE 4.1 - so I need no config-definition.
DE: Wenn in gsconfig.php GSEDITOROPTIONS nicht definiert ist, dann sollte auch nichts eingefügt werden.
In CKE 4.1 ist sowieso eine Toolbar als default.
your GS3.2.1:
Code:
if (defined('GSEDITORTOOL')) { $EDTOOL = GSEDITORTOOL; } else { $EDTOOL = 'basic'; }
if ($EDTOOL == 'advanced') {
...
} else {
$toolbar = GSEDITORTOOL;
}
toolbar :
[
<?php echo $toolbar; ?>
],
my recommentation #2:
Code:
if (defined('GSEDITORTOOL')) { $EDTOOL = GSEDITORTOOL; } else { $EDTOOL = ''; }
if ($EDTOOL == 'advanced') {
...
} else {
$toolbar = GSEDITORTOOL;
}
if (defined('GSEDITORTOOL')) { $toolbar = 'toolbar :['.$toolbar.'],'; }
else { $toolbar = ''; }
<?php echo $toolbar; ?>
!!! - Changes from Toolbar-Buttons will not recognised !!!
LG Wolfgang