MLD email newsletter plugin

[lukinhasb]

There's a bug in this plugin:

If you write a new Newsletter and just click on (Preview and send), without clicking on (Save Newsletter) first, it will send a empty newsletter to the subscribers.

To prevent this, it must be mandatory to save the newsletter before sending it.

-- Edit --

Fixed it:

plugins/mld-newsletter/css/backstyle.css

Code:

/* Add this to the bottom */
.novanewsletter {
    float:right;
    margin-bottom:10px;
}
.save-first {
    text-align:right;
    margin-bottom:10px;
}

plugins/mld-newsletter/lang/en_US.php

PHP Code:

/* Add this anywhere */
$i18n['SAVELETTERINSTRUCTIONS'] = "Save the newsletter first, to then send it."; 


plugins/mld-newsletter.php
Find this:

PHP Code:

<h3><?php i18n('mld-newsletter/EDITLETTER'); ?></h3>
        <div class="VIEWLETTER" ><p><a href="<?php echo $_SERVER['SCRIPT_NAME'] . '?id=mld-newsletter&viewletter=' . $letterid; ?>"><?php i18n('mld-newsletter/VIEWLETTER'); ?></a></p></div>
        <form action="<?php echo $_SERVER['REQUEST_URI']; ?>" method="post" class="mldeditform">
            <p><label class="mldlabel"><?php i18n('mld-newsletter/LETTERTITLE'); ?>:</label> 


Replace with this:

PHP Code:

<h3><?php i18n('mld-newsletter/EDITLETTER'); ?></h3>
        <form action="<?php echo $_SERVER['REQUEST_URI']; ?>" method="post" class="mldeditform">
            
            <?php if ($letterid != '<new>') { ?>
                   <div class="edit-nav novanewsletter" ><p><a href="<?php echo $_SERVER['SCRIPT_NAME'] . '?id=mld-newsletter&viewletter=' . $letterid; ?>"><?php i18n('mld-newsletter/VIEWLETTER'); ?></a></p></div>    
               <?php } else {?>
                    <label for="saveletter" class="save-first"><?php i18n('mld-newsletter/SAVELETTERINSTRUCTIONS'); ?></label>
                    <input type="submit" class="submit novanewsletter" value="<?php i18n('mld-newsletter/SAVELETTER'); ?>" id="saveletter" name="saveletter" />
            <?php } ?>
            
            <p><label class="mldlabel"><?php i18n('mld-newsletter/LETTERTITLE'); ?>:</label>