Download
Minor:
Your plugin is called GS Custom Settings, but the file and folder are named custom_settings. I just thought it makes sense to use the same name for your files.. I just thought, since custom settings is very general in name, you higher the risk that someone takes the same file-names for a plugin in the future (he would not know of you using it, since your plugin has a different name), overwriting your files. Maybe this is nonsense, I don't know.
I still see v. 0.3 and an update warning for v. 0.4 in Plugins section.
In the plugin registration it shows v. 0.3:
You can't delete a setting if it's the only setting. If you select multiple settings you can delete them all.
Major:
When I try to reorder the tabs, that is not done correctly. Tabs randomly move to a certain position with every click, can't see a pattern.
(2015-05-23, 09:11:49)Tyblitz Wrote:I still see what you can see in the screenshot when loading that plugin admin page, but only for a short time during loading. Looks a bit crappy. Not an issue, but maybe something you want to look into what's going on in the future.(2015-05-23, 08:48:21)datiswous Wrote: Tried this just now, but all previous settings made with v0.3 are gone and default 2 tabs active:
In combination with GSconfig UI there's more weird stuff...
Edit: It seems to work now. Maybe best to flush cache after update?
Yeah I had a similar issue & was surprised after so many succesful tests. Solved it by simply reloading the page, I'll have to add that to the install description. Thanks for reminding me.
Your plugin is called GS Custom Settings, but the file and folder are named custom_settings. I just thought it makes sense to use the same name for your files.. I just thought, since custom settings is very general in name, you higher the risk that someone takes the same file-names for a plugin in the future (he would not know of you using it, since your plugin has a different name), overwriting your files. Maybe this is nonsense, I don't know.
I still see v. 0.3 and an update warning for v. 0.4 in Plugins section.
In the plugin registration it shows v. 0.3:
Code:
// register plugin
register_plugin(
'custom_settings',
$custom_settings_lang['title'],
'0.3',
'Kevin Van Lierde',
'http://webketje.github.io',
$custom_settings_lang['descr'],
'site',
'custom_settings_init'
);You can't delete a setting if it's the only setting. If you select multiple settings you can delete them all.
Major:
When I try to reorder the tabs, that is not done correctly. Tabs randomly move to a certain position with every click, can't see a pattern.
