Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Simple Input Tabs
#62
(2012-11-08, 18:32:08)hameau Wrote: Hello,

Looks pretty useful at first glance – thanks! It should make things easier when explaining the site admin. to lay editors.

A couple of points:
- there's a lot of redundant Mac stuff in the distributed .zip;
- with debug on, there are several 'Uninitialized string offset' and 'Undefined index' notices from PHP in simple_input_tabs.php.

I'm using GS 3.1.2, PHP 5.3.3 and SIT 1.8c. Several other plugins are installed, but disabled.

Hmm. By redundant mac stuff, are you referring to "hidden" spotlight files or some such? I could have sworn I didn't put any in there, but I could be wrong. Files like .DS_store?

I'll have to check out your errors.

Quote:Edit to add:
Just changing (Simple Input) tabs on the Edit page marks the page content as changed, so there's a warning if the page edit is aborted, even if none of the content has been changed. This means that just going to look at/check a site page's content in the editor can lead to unnecessary pop-ups. Not a big deal, but a bit clunky.

For a new page, is there any way to get a change of page template without having to save the page first? Again, not really a big deal, except that it's necessary to have a page title before saving, which no-one will know until they get the error message. So then they enter the page title and click 'Save Page' again, not realising that their previous template change has been reset by the save error. This will take some explaining (and troubleshooting effort from the user). (Any content will also be lost, but that's not a fault of SIT.)

Yeah I know what you're saying. This was an executive decision I had to make and it may not have been the correct one. Tongue
For a reason I have yet to fully grasp. When changing the content via Javascript (ie tab switch), the process breaks the CMS's ability to check for changes on that field. So if you changed a tab then typed in something, it would not register the changes anymore in the main content field and would not warn you that content had been changed (though changes anywhere else still work fine, like changing the title etc). So I have some good news. That warning is actually added in there manually and can be easily deleted if you like.
To remove it navigate to this section at around line 478:

Code:
warnme = true;// As content changing breaks the ability to bind actions. Set warnings for tab changes.
$('#pagechangednotify').show();
$('#pagechangednotify').text('Page has unsaved changes');
$('input[type=submit]').css('border-color','#CC0000');
$('#cancel-updates').show();

If you delete all that then it will no longer warn you when changing tabs. If you delete only the "warnme = true" part then the popup will be gone and the red border around the save button and "page unsaved changes" will still turn on upon changing tabs.

There is a secondary warning too, which you can choose to leave or delete (turn off). When clicking on the magnifying glass to bring up the tab locations, and then clicking on a tab. It will warn you before redirecting the page to that tabs location. To remove that warning navigate to this part of the code at line 204:

Code:
$link_begin = '<element'.$hand.'onClick="window.opener.location.reload(true);window.opener.warnme=true;window.opener.location.href=\''.get_site_url(false).'/admin/edit.php?id=';

And remove this section from within there:

Code:
window.opener.warnme=true;

As to the template thing. Yeah I know that is a pain. There is one semi-work around, which is to use "insert_page_content();" with empty brackets for your main content as that will follow through to any other template that uses it. Should be noted that information is never really deleted, but hidden. If a page has information filled in and the template is swapped to a new one without that tab name. The info will sit there dormant until a template with the tab name is made active again. I'm thinking about adding a config screen with a "clear all unused tabs" button at some stage, just to clear out extra information.

Fear not. Sorting out that dropdown is on my todo list. Definitely. Any development tips would be great too!

Thanks a lot for the feedback! I'm glad you're liking this. Let me know if you have any more suggestions or ideas. Smile
Reply


Messages In This Thread
Simple Input Tabs - by jason.dixon.email - 2012-10-19, 22:59:03
RE: Simple Input Tabs - by islander - 2012-10-30, 19:30:59
RE: Simple Input Tabs - by jason.dixon.email - 2012-10-31, 03:34:11
RE: Simple Input Tabs - by stevenatherton42 - 2012-10-31, 05:56:17
RE: Simple Input Tabs - by islander - 2012-10-31, 06:23:31
RE: Simple Input Tabs - by stevenatherton42 - 2012-10-31, 06:30:52
RE: Simple Input Tabs - by jason.dixon.email - 2012-10-31, 11:02:48
RE: Simple Input Tabs - by stevenatherton42 - 2012-10-31, 11:28:30
RE: Simple Input Tabs - by jason.dixon.email - 2012-10-31, 12:03:12
RE: Simple Input Tabs - by jason.dixon.email - 2012-10-31, 23:39:08
RE: Simple Input Tabs - by islander - 2012-11-01, 02:45:39
RE: Simple Input Tabs - by stevenatherton42 - 2012-11-01, 08:43:19
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-01, 11:53:37
RE: Simple Input Tabs - by stevenatherton42 - 2012-11-01, 12:09:05
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-01, 15:04:04
RE: Simple Input Tabs - by stevenatherton42 - 2012-11-03, 04:11:50
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-03, 09:46:05
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-03, 11:27:10
RE: Simple Input Tabs - by shovenose - 2012-11-03, 16:12:34
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-07, 23:43:18
RE: Simple Input Tabs - by islander - 2012-11-08, 02:07:06
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-08, 03:26:39
RE: Simple Input Tabs - by islander - 2012-11-08, 03:42:27
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-08, 03:54:36
RE: Simple Input Tabs - by hameau - 2012-11-08, 18:32:08
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-08, 21:12:49
RE: Simple Input Tabs - by hameau - 2012-11-08, 22:22:50
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-08, 22:39:37
RE: Simple Input Tabs - by hameau - 2012-11-09, 01:50:38
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-09, 02:14:57
RE: Simple Input Tabs - by hameau - 2012-11-09, 03:18:47
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-09, 11:24:00
RE: Simple Input Tabs - by hameau - 2012-11-10, 04:58:50
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-10, 05:04:18
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-10, 21:58:05
RE: Simple Input Tabs - by hameau - 2012-11-10, 23:21:13
RE: Simple Input Tabs - by uitdecom - 2012-11-10, 23:42:15
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-11, 06:18:19
RE: Simple Input Tabs - by hameau - 2012-11-12, 04:56:17
RE: Simple Input Tabs - by hameau - 2012-11-11, 01:54:51
RE: Simple Input Tabs - by Timbow - 2012-11-11, 23:10:01
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-12, 07:50:11
RE: Simple Input Tabs - by hameau - 2012-11-13, 02:41:59
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-13, 03:37:52
RE: Simple Input Tabs - by hameau - 2012-11-13, 06:53:17
RE: Simple Input Tabs - by Timbow - 2012-11-13, 21:43:12
RE: Simple Input Tabs - by hameau - 2012-11-13, 22:52:22
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-14, 01:59:54
RE: Simple Input Tabs - by islander - 2012-11-14, 06:45:58
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-14, 08:46:21
RE: Simple Input Tabs - by islander - 2012-11-14, 09:04:15
RE: Simple Input Tabs - by uitdecom - 2012-11-16, 04:09:15
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-16, 12:19:25
RE: Simple Input Tabs - by uitdecom - 2012-11-16, 19:20:58
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-16, 21:00:03
RE: Simple Input Tabs - by uitdecom - 2012-11-16, 21:30:04
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-16, 22:10:08
RE: Simple Input Tabs - by uitdecom - 2012-11-16, 22:19:02
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-16, 22:38:54
RE: Simple Input Tabs - by uitdecom - 2012-11-16, 22:44:50
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-16, 23:10:26
RE: Simple Input Tabs - by uitdecom - 2012-11-17, 00:23:24
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-17, 01:14:37
RE: Simple Input Tabs - by uitdecom - 2012-11-17, 01:45:05
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-17, 01:57:29
RE: Simple Input Tabs - by uitdecom - 2012-11-17, 02:08:14
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-17, 02:16:22
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-21, 02:36:11
RE: Simple Input Tabs - by islander - 2012-11-21, 03:54:48
RE: Simple Input Tabs - by jason.dixon.email - 2012-11-21, 12:50:25
RE: Simple Input Tabs - by islander - 2012-11-21, 19:12:57
RE: Simple Input Tabs - by tazmandev - 2012-12-09, 06:18:26
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-09, 09:25:07
RE: Simple Input Tabs - by shawn_a - 2012-12-11, 10:53:04
RE: Simple Input Tabs - by Timbow - 2012-12-12, 04:04:29
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-12, 12:16:56
RE: Simple Input Tabs - by datiswous - 2012-12-13, 04:43:19
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-13, 13:54:49
RE: Simple Input Tabs - by shawn_a - 2012-12-13, 06:40:41
RE: Simple Input Tabs - by datiswous - 2012-12-13, 06:50:16
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-13, 12:43:56
RE: Simple Input Tabs - by shawn_a - 2012-12-14, 00:51:01
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-14, 02:14:58
RE: Simple Input Tabs - by shawn_a - 2012-12-14, 03:41:16
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-14, 23:09:39
RE: Simple Input Tabs - by datiswous - 2012-12-15, 08:22:14
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-18, 03:11:27
RE: Simple Input Tabs - by Timbow - 2012-12-19, 20:45:01
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-19, 22:00:24
RE: Simple Input Tabs - by Timbow - 2012-12-19, 23:29:14
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-20, 02:28:25
RE: Simple Input Tabs - by Timbow - 2012-12-22, 09:40:25
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-22, 13:03:35
RE: Simple Input Tabs - by Timbow - 2012-12-28, 10:48:01
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-29, 00:25:56
RE: Simple Input Tabs - by Timbow - 2012-12-29, 03:20:31
RE: Simple Input Tabs - by lukastaylor - 2012-12-30, 09:16:59
RE: Simple Input Tabs - by jason.dixon.email - 2012-12-31, 12:30:42
RE: Simple Input Tabs - by lukastaylor - 2013-01-01, 03:46:42
RE: Simple Input Tabs - by jason.dixon.email - 2013-01-01, 03:56:23
RE: Simple Input Tabs - by lukastaylor - 2013-01-01, 04:01:37
RE: Simple Input Tabs - by jason.dixon.email - 2013-01-01, 12:42:29
RE: Simple Input Tabs - by lukastaylor - 2013-01-02, 00:24:12
RE: Simple Input Tabs - by jason.dixon.email - 2013-01-02, 00:36:17
RE: Simple Input Tabs - by lukastaylor - 2013-01-02, 02:14:12
RE: Simple Input Tabs - by jason.dixon.email - 2013-01-02, 02:39:21
RE: Simple Input Tabs - by lukastaylor - 2013-01-02, 02:40:37
RE: Simple Input Tabs - by Timbow - 2013-01-22, 02:20:06
RE: Simple Input Tabs - by jason.dixon.email - 2013-01-22, 02:56:55
RE: Simple Input Tabs - by Timbow - 2013-01-22, 06:09:58
RE: Simple Input Tabs - by jason.dixon.email - 2013-01-23, 03:24:17
RE: Simple Input Tabs - by Carlos - 2013-01-23, 04:14:30
RE: Simple Input Tabs - by jason.dixon.email - 2013-01-23, 21:13:12
RE: Simple Input Tabs - by mvlcek - 2013-01-23, 21:48:46
RE: Simple Input Tabs - by jason.dixon.email - 2013-01-29, 01:06:19
RE: Simple Input Tabs - by shawn_a - 2013-01-29, 01:19:04
RE: Simple Input Tabs and i18n - by jezok - 2013-03-14, 18:03:49
RE: Simple Input Tabs and i18n - by jezok - 2013-03-14, 22:02:04
RE: Simple Input Tabs and i18n - by jezok - 2013-03-15, 05:06:59
RE: Simple Input Tabs - by jason.dixon.email - 2013-03-17, 18:47:59
RE: Simple Input Tabs - by jason.dixon.email - 2013-03-18, 23:01:50
RE: Simple Input Tabs - by tazmandev - 2013-03-31, 05:08:44
RE: Simple Input Tabs - by jason.dixon.email - 2013-03-31, 16:15:39
RE: Simple Input Tabs - by jason.dixon.email - 2013-04-02, 13:34:55
RE: Simple Input Tabs - by tazmandev - 2013-04-02, 21:09:10
RE: Simple Input Tabs - by shawn_a - 2013-04-03, 00:01:16
RE: Simple Input Tabs - by tazmandev - 2013-04-03, 02:06:47
RE: Simple Input Tabs - by jason.dixon.email - 2013-04-03, 21:16:45
RE: Simple Input Tabs - by shawn_a - 2013-04-03, 22:59:59
RE: Simple Input Tabs - by jason.dixon.email - 2013-04-05, 18:40:29
RE: Simple Input Tabs - by tazmandev - 2013-04-08, 19:33:35
RE: Simple Input Tabs - by jason.dixon.email - 2013-04-08, 22:40:52
RE: Simple Input Tabs - by hempelr - 2013-06-24, 22:32:50
RE: Simple Input Tabs - by jason.dixon.email - 2013-06-25, 02:08:54
RE: Simple Input Tabs - by hempelr - 2013-06-25, 16:45:56
RE: Simple Input Tabs - by jason.dixon.email - 2013-06-25, 17:46:28
RE: Simple Input Tabs - by villeristi - 2013-09-19, 01:30:55
RE: Simple Input Tabs - by jason.dixon.email - 2013-09-19, 06:56:39
RE: Simple Input Tabs - by villeristi - 2013-09-19, 08:13:23
RE: Simple Input Tabs - by jason.dixon.email - 2013-09-19, 16:46:28
RE: Simple Input Tabs - by villeristi - 2013-09-19, 16:58:14
RE: Simple Input Tabs - by bensayers - 2014-01-17, 11:07:37
RE: Simple Input Tabs - by jason.dixon.email - 2014-01-17, 13:18:21
RE: Simple Input Tabs - by bensayers - 2014-01-17, 17:20:52
RE: Simple Input Tabs - by jason.dixon.email - 2014-01-18, 00:08:41
RE: Simple Input Tabs - by bensayers - 2014-01-18, 05:29:35
RE: Simple Input Tabs - by jason.dixon.email - 2014-01-18, 05:39:27
RE: Simple Input Tabs - by jason.dixon.email - 2014-01-19, 11:01:02
RE: Simple Input Tabs - by Thomas Helzle - 2014-04-12, 21:05:56
RE: Simple Input Tabs - by Thomas Helzle - 2014-04-12, 21:10:57
RE: Simple Input Tabs - by jason.dixon.email - 2014-04-13, 06:46:32
RE: Simple Input Tabs - by Thomas Helzle - 2014-04-13, 08:53:47
RE: Simple Input Tabs - by Thomas Helzle - 2014-04-15, 04:05:22
RE: Simple Input Tabs - by danielg - 2014-07-08, 19:20:12
RE: Simple Input Tabs - by tazmandev - 2014-07-08, 21:10:01
RE: Simple Input Tabs - by mvlcek - 2014-07-09, 03:36:52
RE: Simple Input Tabs - by jason.dixon.email - 2014-07-08, 21:22:40
RE: Simple Input Tabs - by danielg - 2014-07-21, 20:11:34
RE: Simple Input Tabs - by datiswous - 2015-02-16, 21:01:55
RE: Simple Input Tabs - by shawn_a - 2018-03-24, 00:36:10
Simple Input Tabs - by datiswous - 2012-10-21, 15:18:09
Simple Input Tabs - by jason.dixon.email - 2012-10-21, 15:35:30
Simple Input Tabs - by islander - 2012-10-22, 06:34:06
Simple Input Tabs - by jason.dixon.email - 2012-10-22, 07:44:55
Simple Input Tabs - by datiswous - 2012-10-22, 09:00:55
Simple Input Tabs - by jason.dixon.email - 2012-10-22, 14:33:41
Simple Input Tabs - by islander - 2012-10-23, 00:24:29
Simple Input Tabs - by yojoe - 2012-10-23, 01:21:14
Simple Input Tabs - by jason.dixon.email - 2012-10-23, 02:01:24
Simple Input Tabs - by jason.dixon.email - 2012-10-23, 02:06:03
Simple Input Tabs - by jason.dixon.email - 2012-10-24, 22:27:49
Simple Input Tabs - by islander - 2012-10-25, 08:16:34
Simple Input Tabs - by islander - 2012-10-25, 19:45:08
Simple Input Tabs - by jason.dixon.email - 2012-10-26, 02:47:55
Simple Input Tabs - by islander - 2012-10-26, 07:53:56
Simple Input Tabs - by ChriS - 2012-10-26, 09:31:30
Simple Input Tabs - by jason.dixon.email - 2012-10-26, 11:30:35
RE: Simple Input Tabs - by ChriS - 2012-10-30, 09:21:22
RE: Simple Input Tabs - by jason.dixon.email - 2012-10-31, 01:07:02
Simple Input Tabs - by islander - 2012-10-26, 19:12:18
Simple Input Tabs - by jason.dixon.email - 2012-10-27, 00:55:06
Simple Input Tabs - by islander - 2012-10-27, 01:05:04
Simple Input Tabs - by jason.dixon.email - 2012-10-27, 01:08:54
Simple Input Tabs - by islander - 2012-10-27, 01:27:11
Simple Input Tabs - by jason.dixon.email - 2012-10-27, 02:55:21
Simple Input Tabs - by islander - 2012-10-27, 04:01:25
Simple Input Tabs - by uitdecom - 2012-10-27, 07:31:44
Simple Input Tabs - by jason.dixon.email - 2012-10-27, 12:17:00
Simple Input Tabs - by jason.dixon.email - 2012-10-27, 12:23:58
Simple Input Tabs - by islander - 2012-10-27, 20:35:02
Simple Input Tabs - by Timbow - 2012-10-27, 23:39:12
Simple Input Tabs - by jason.dixon.email - 2012-10-28, 12:25:42
Simple Input Tabs - by jason.dixon.email - 2012-10-28, 12:31:10
Simple Input Tabs - by jason.dixon.email - 2012-10-28, 15:41:25
Simple Input Tabs - by islander - 2012-10-28, 19:04:06
Simple Input Tabs - by jason.dixon.email - 2012-10-29, 05:44:34



Users browsing this thread: 1 Guest(s)