'Multi User 1.4' Plugin

[ccagle8]

Wow, i must say Mike - this is a great job. A few things that I noticed:

1. you hide the top nav links, but the bottom footer links do not hide. I am thinking of adding a class to each one as I have for the top nav links so when you hide ".theme" you hide both. However, this obviously wont be until 3.1 gets released.

2. if you do not have "all" the permissions, you shouldn't be allowed to edit your own permissions. i am assuming that if you have all permissions - you are an administrator.

3. i think to make the user.xml file cleaner - you should make the format like this:

Code:

$xml = new SimpleXMLElement('<item></item>');
    $xml->addChild('USR', $NUSR);
    $xml->addChild('PWD', $NPASSWD);
    $xml->addChild('EMAIL', $NEMAIL );
    $xml->addChild('HTMLEDITOR', $NHTMLEDITOR);
    $xml->addChild('TIMEZONE', $NTIMEZONE);
    $xml->addChild('LANG', $NLANG);
    $perm = $xml->addChild('PERMISSIONS');
    $perm->addChild('PAGES', $NPAGES);
    $perm->addChild('FILES', $NFILES);
    $perm->addChild('THEME', $NTHEME);
    $perm->addChild('PLUGINS', $NPLUGINS);
    $perm->addChild('BACKUPS', $NBACKUPS);
    $perm->addChild('SETTINGS', $NSETTINGS);
    $perm->addChild('SUPPORT', $NSUPPORT);
    $perm->addChild('EDIT', $NEDIT);

4. Why didnt you reuse the timezone <select> code from settings.php? Check out Line 222 in settings.php
5. To read the system's available languages, you can rip the code from settings.php as well: Line 153
6. .show("slow") and .hide("slow") make the page look sluggish when it really isnt. i would personally prefer just to use the default speed or change it to .slideDown() and .slideUp() respectively


overall - very very nice plugin Mike. I also think that you should add some type of disclaimer within the Extend section explaining that permissions only "hide functionality" not actually "disable functionality" from the end user.