Guestbook

[cumbe]

1)

I noticed, that you run into an error when you have defined $lang in gsconfig.php but the corresponding language file is not created and/or uploaded yet.

lin 97 in comprueba.php:

Code:

//llamamos archivo idiomas: array i18n de plugin
         include ('lang/'.$LANG.'.php');

I think a fallback to "english" if not exist would be better, what's your idea?

R: Yes, you are right...
Of all points, this is the only important. Other points are related with the work of who design a web, not of a developer...

2)

When the captcha is entered wrong, the correct captcha-code and the wrong entered captcha-code are shown on the next website (not in AJAX in the same site)
and this text appears:

Redirection in 2 seconds. If you do not redirection push Back

a) why show the correct and wrong code? When there was a mistake, you cannot correct it as the next loaded captcha will demand other string
b) 2 seconds is too short... if you want the people to read the message, but I think it would be better to show the error text directly in the guestbook.page
c) the text should be read from the language file! No english text for non-english users

I attach an uptodate german language file here

R: a) If you have a mistake, the system tell you,...
b) to me i like it so...
c) In next version, will read from language file...

3)

the text "'View contactform.log'," in the en_EN-language file is wrong. I think it should be "

'View guestbook.log',

also

"CONTACT_FORM_SUB" => 'Contact Form Submission',

R: it is of other plugin, and does not influence this... but in the next version i removed this fields...


4)

I also do not understand why the language file en_EN is stil in ASCII, a real quiz question ;=)

R: i neither... in linux UTF-8, in windows ANSI ¿?¿?¿?

5)

what is this in guestbook.php in line 267?
When I discomment, nothing happens (there is no guestbook-name set)

<!-- if you want that show the name of guestbook, discomment the next line -->
<!-- <div style="font-size:35px; letter-spacing:1px; line-height:35px; margin:22px 20px 10px;"><?php //echo i18n('guestbook/GBOOK'); ?></div> -->

R: becuase you must discomment html and php:

Code:

<div style="font-size:35px; letter-spacing:1px; line-height:35px; margin:22px 20px 10px;"><?php echo i18n('guestbook/GBOOK'); ?></div>

6)

comprueba.php, line 117:

$from = 'no-reply@get-simple.info';

I think this mail-adress should be pulled from a setting

R: Now if you remove this line does not happend anything, then in the next version this line will be removed...


7)

guestbook.php, lines 376:
in german the header of the form reads:

geschrieben am July 21st, 2011 - 3:28 PM

the date format is wrong, where do you get the date format from?
it is no german date

R: in lines +- 376 and +- 440,

Code:

else if ($n == 'date'){
                    $d = substr($d,0,strpos($d,'+')-1);

                      $d = lngDate($d);...

use a function of getsimple lngDate...
You must read: http://get-simple.info/forum/topic/720/p...tion-date/

8)

you must separate content from layout
your layout breask all CSS from any website, you must give IDs or classes to the table elements, not place the css in the code

I do need a guestbook for a client site, but as it is now, I cannot integrate it. "Our" site is green not gradient red...

R: yes or no or yes or no. This is free. I think that is easy to make the changes that you needs. Moreover, you already have a css as i have seen in http://www.urbanistan.de/getsimple/plugi...uchplugin/

and the form is absolutely ugly ...

R: ...then modify it. Iḿ not a designer...
I think the important thing is that the system works; everyone has to adapt to your style...

PD: to me to write it, i takes a long time and i have little...

Greetings and kisses....