Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
ResponsiveCE
#1
Starter template preinstalled on GetSimple CMS CE users added on 3.3.18.1 fixed with many option. (works on official 3.3.16)
responsive
dark/light mode
bootstrap turn on/off
based on vanilla css and pico.css
3 different theme grid
own logo url on title on header
How change option? Go to theme files after activated and edit functions.php

[Image: screenshot.png]
Download:
Version CE:
DEMO:
Reply
#2
Thumbs Up 
Cool. More free stuff. Cool

I wanted to change my theme since some years now, but I have some adapted things in my theme and I am shying away from all the work...
Reply
#3
Hi!

I checked the header.inc.php and I see there are referers to cdn.cloudflare

as this is a sensitive point in relation to DSGVO, I would like to know if it is possible to delete these referers

Code:
<?php echo ($bootstrap !== 'yes' ?  '' : '<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/5.2.3/css/bootstrap-grid.min.css" integrity="sha512-JQksK36WdRekVrvdxNyV3B0Q1huqbTkIQNbz1dlcFVgNynEMRl0F8OSqOGdVppLUDIvsOejhr/W5L3G/b3J+8w==" crossorigin="anonymous" referrerpolicy="no-referrer" />'); ?>
Code:
<link rel="stylesheet" type="text/css" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/css/all.min.css">
|--

Das deutschsprachige GetSimple-(Unter-)Forum:   http://get-simple.info/forums/forumdisplay.php?fid=18
Reply
#4
Simply removing these will break the theme. These will need to be added to the assets folder and their address updated.

I understand your DSGVO concerns and will see if this can be updated in the next release.


GS Community Edition with php8.x compatibility, new features and much more!  Support Me


Reply
#5
Actually Connie, I may have spoken too soon. I think those two lines can be deleted without collapsing the theme. You may loose a few icons, but it should be fine.

Give it a go and if there is a problem report back.


GS Community Edition with php8.x compatibility, new features and much more!  Support Me


Reply
#6
(2024-07-29, 03:20:06)islander Wrote: Actually Connie, I may have spoken too soon. I think those two lines can be deleted without collapsing the theme. You may loose a few icons, but it should be fine.

Give it a go and if there is a problem report back.

I commented out these two lines in header.inc  and I will check how it goes ;=)

1) font-awesome is problematic for DSGVO
2) the bootstrap directive is not necessary when it is configured in functions.php:

in functions.php:

Code:
/*
you want use bootstrap grid cdn on your theme?
$bootstrap = 'yes' - use cdn
$bootstrap = 'no' or '' - default css
*/

is it a good idea to add a GDPR / DSGVO - section in the general sections where all these things are easy to regulate?
|--

Das deutschsprachige GetSimple-(Unter-)Forum:   http://get-simple.info/forums/forumdisplay.php?fid=18
Reply
#7
If it works for you, then great idea.

I personally only use the functions.php/settings.php in pre-made templates as suggestions or examples of how to use.


GS Community Edition with php8.x compatibility, new features and much more!  Support Me


Reply
#8
(2024-07-29, 19:28:15)islander Wrote: If it works for you, then great idea.

I personally only use the functions.php/settings.php in pre-made templates as suggestions or examples of how to use.

I will try to include bootstrap locally instead of loading from cloudflare.

I think this is much better an idea as it reduces the load from other servers and is GDPR / DSGVO-conform

I will tell you how it works

Cheers, Connie
|--

Das deutschsprachige GetSimple-(Unter-)Forum:   http://get-simple.info/forums/forumdisplay.php?fid=18
Reply
#9
This should be fine.
We have been doing this to other plugins and themes as well for this reason.
Including the old Innovation theme.
But have not gotten around to some and forgot about others.


GS Community Edition with php8.x compatibility, new features and much more!  Support Me


Reply
#10
(2024-07-30, 18:18:51)islander Wrote: This should be fine.
We have been doing this to other plugins and themes as well for this reason.
Including the old Innovation theme.
But have not gotten around to some and forgot about others.

Let me list some questions here ;=)
  • functions.php offers options, but no options whether you want to use "container" or "container-fluid" as "bootstrap-starter"
    why not add the option "fixed size (= "container") or "responsive 100% width (="container-fluid")?
  • I think it would be easier to understand the theme if the names for the divs in the template show the column-definition, f.e. "col-8" or "col-3" instead of defining them in the css file. e.q.

    content-grid {
    ...
    grid-column: 1fr;
    ---
    }

  • I had to study some bootstrap tutorials and learned that "bootstrap" consists of css- files and js-files
    But I see no js-files for bootstrap in the theme's js-folder
    Does this mean that getsimple provides the bootstrap-js? Where?

  • will there be conflicts when GS has it's own bootstrap fles and the theme-template loads it's own bootstrap.js ?

  • I would love to have a WIKI-site explaining GS + Bootstrap and also some readme for your theme ;=)
    It took me some time to find out that some settings are done in functions.php, and "normal users" usually are not eager readers of php-files
I have to make a grid-theme with 12 columns and fixed widths via css  responsive and is not a simple task  Wink

Cheers, Connie
|--

Das deutschsprachige GetSimple-(Unter-)Forum:   http://get-simple.info/forums/forumdisplay.php?fid=18
Reply
#11
Hello Connie,

The theme has been updated to include bootstrap and fa and not use cloudflare to better comply with gdpr.

Adding a wiki to the site is planned, but I dont know when it will happen at the moment.

The .js file from bootstrap includes additional functions that are not used in this theme, so it was not included.
If you are not loading css or js files twice on the same page, there should not be conflicts. But if you do find any, please report.

Bootstrap is a very robust and widely used framework with lots of options and possibilities. It is not possible to include everything, as much of it is personal preference.

You are welcome to post improvements here or directly on https://github.com/GetSimpleCMS-CE-themes/ResponsiveCE and Multi will eventually see it. But at the moment he is short of time.


GS Community Edition with php8.x compatibility, new features and much more!  Support Me


Reply
#12
Hi Islander, thank you for your answers!

Now I am more confident to judge how to update a certain theme layout to make it responsible. It is a layout with nearly no interactive elements so no buttons or ctas are necessary, just a contact form ..

My challenge is now to decide whether to use Bootstrap or a CSS grid system

I am on a learning curve ;=)
|--

Das deutschsprachige GetSimple-(Unter-)Forum:   http://get-simple.info/forums/forumdisplay.php?fid=18
Reply




Users browsing this thread: 1 Guest(s)