Download
2012-07-12, 01:02:45
shawn_a Wrote:FYI, some things I noticed with your plugins.
Your javascript for hiding the pages sidemenus is active on all pages not just pages page.
I'll change it - any problems with this so far?
shawn_a Wrote:Also your not using createsidemenus or nav tab for sidemenus and tabs which might cause your plugin to break if we make changes to core. For example the new sidemenu and tab classes that we added to those menus.
Naturally, as those functions did not exist with this functionality before GS 3.1 and were updated/created based on my code in 3.1. I'll try to detect GS 3.1+ and use the native functions.
shawn_a Wrote:oh and if you change your sidemenu hooks to register on front end also , they will work with my adminbar plugin automatically.
Oh god, I optimize my plugins as best as possible and then a certain individual creates an adminbar plugin... ;-)
