Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
php 8.x plugin support repo
#1
I started fix plugins for community. Today i18n - what next?
or our project with Islander get simple community edition website
 
Reply
#2
(2022-10-11, 20:43:37)multicolor Wrote:
I started fix plugins for community. Today i18n - what next?
or our project with Islander get simple community edition website
 

It would be nice to fix the whole line of plugins I18N.
Reply
#3
(2022-10-11, 20:43:37)multicolor Wrote:
I started fix plugins for community. Today i18n - what next?
or our project with Islander get simple community edition website
 

Dear @multicolor,

Thanks for providing Get Simple Community Edition and also for Plugin Fixes.

We have noticed following Error Message in i18n_navigation Plugin [after applying Fixes]:
[16-Oct-2022 18:29:06 Asia/Kolkata] PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_navigation/editextras.php on line 11
PHP Code:
    foreach (preg_split('/\s*,\s*/'trim(@$page['tags'])) as $t$tags[$t] = true

We are also noticing following Error Messages in other Plugins:
[16-Oct-2022 18:20:51 Asia/Kolkata] PHP Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searchform.php on line 80
PHP Code:
  <input type="text" name="words" class="search-words" value="<?php echo htmlspecialchars(@$_REQUEST['words']); ?>" <?php if ($placeholderText) echo 'placeholder="'.htmlspecialchars($placeholderText).'"'?>/> 
[16-Oct-2022 18:27:19 Asia/Kolkata] PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searcher.class.php on line 261
PHP Code:
$this->tags is_array($tags) ? $tags : (trim($tags) != '' preg_split("/\s+/"trim($tags)) : array()); 
[16-Oct-2022 18:27:19 Asia/Kolkata] PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searcher.class.php on line 264  
PHP Code:
$order trim($order); 
[16-Oct-2022 18:21:15 Asia/Kolkata] PHP Deprecated:  preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/xxxx/public_html/plugins/pagify.php on line 96
PHP Code:
if (!preg_match('/^hr|(\d+)\s*([a-zA-Z]*)$/',$pageSize,$match)) return $content

Please guide us in this regard.

Thanks,
Reply
#4
(2022-10-17, 01:24:01)celextel Wrote:
(2022-10-11, 20:43:37)multicolor Wrote:
I started fix plugins for community. Today i18n - what next?
or our project with Islander get simple community edition website
 

Dear @multicolor,

Thanks for providing Get Simple Community Edition and also for Plugin Fixes.

We have noticed following Error Message in i18n_navigation Plugin [after applying Fixes]:
[16-Oct-2022 18:29:06 Asia/Kolkata] PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_navigation/editextras.php on line 11
PHP Code:
    foreach (preg_split('/\s*,\s*/'trim(@$page['tags'])) as $t$tags[$t] = true

We are also noticing following Error Messages in other Plugins:
[16-Oct-2022 18:20:51 Asia/Kolkata] PHP Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searchform.php on line 80
PHP Code:
  <input type="text" name="words" class="search-words" value="<?php echo htmlspecialchars(@$_REQUEST['words']); ?>" <?php if ($placeholderText) echo 'placeholder="'.htmlspecialchars($placeholderText).'"'?>/> 
[16-Oct-2022 18:27:19 Asia/Kolkata] PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searcher.class.php on line 261
PHP Code:
$this->tags is_array($tags) ? $tags : (trim($tags) != '' preg_split("/\s+/"trim($tags)) : array()); 
[16-Oct-2022 18:27:19 Asia/Kolkata] PHP Deprecated:  trim(): Passing null to parameter #1 ($string) of type string is deprecated in /home/xxxx/public_html/plugins/i18n_search/searcher.class.php on line 264  
PHP Code:
$order trim($order); 
[16-Oct-2022 18:21:15 Asia/Kolkata] PHP Deprecated:  preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /home/xxxx/public_html/plugins/pagify.php on line 96
PHP Code:
if (!preg_match('/^hr|(\d+)\s*([a-zA-Z]*)$/',$pageSize,$match)) return $content

Please guide us in this regard.

Thanks,

What version php you test it? I test only i18n - soon i i18n search and rest i18n support. Maybe this is why you saw error.
Reply
#5
(2022-10-17, 06:16:30)multicolor Wrote: What version php you test it? I test only i18n - soon i i18n search and rest i18n support. Maybe this is why you saw error.

PHP Version: 8.1.9

We have just noticed another Error Log Message in regard to i18n_navigation Plugin [after applying Fixes]:
[17-Oct-2022 12:39:54 Asia/Kolkata] PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; I18nNavigationItem has a deprecated constructor in /home/XXXX/public_html/plugins/i18n_navigation/frontend.class.php on line 349
PHP Code:
class I18nNavigationItem 
Reply
#6
Backups.php seems not work on CE-version
Reply
#7
(2022-10-21, 18:54:54)kdxfi Wrote: Backups.php seems not work on CE-version

Works after create some content - try.
Reply
#8
I18n Gallery now on php 8.x repo. Soon next plugins.

https://github.com/multicolor-rgb/GetSim...8n-gallery
Reply
#9
3.4 cleaned up for php 7.4+


Attached Files Thumbnail(s)
   
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#10
It would be nice to have a patch repo, for patching plugins, without hosting actual code as we have no idea what the various licenses are. So like a patcher script but that would be hard without versioning
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#11
(2022-10-27, 06:03:18)shawn_a Wrote: It would be nice to have a patch repo, for patching plugins, without hosting actual code as we have no idea what the various licenses are. So like a patcher script but that would be hard without versioning

Look what people search, version patched ready to use - no patched files. For some user replace file to another on plugin is to difficult. Now we try something like this, we try help community no theft something. I hope authors leaved project understand this.
Reply
#12
(2022-10-27, 06:00:28)shawn_a Wrote: 3.4 cleaned up for php 7.4+

Great, but still alpha/beta - no stable version i think?
Reply
#13
I have a repo with all popular plugins for this

https://github.com/GetSimpleCMS/Plugins/...er/plugins
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#14
We need to pin this in the forum
Reply
#15
I am working on a setting up a dev enviroment for this using rector to auto migrate the entire repo.
Not sure if it will work on proceedural code without classes, i have never used it before.

If you are a php developer please hit me up on the discord
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#16
I need plugins to fix, give me examples
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#17
(2022-10-27, 23:18:46)shawn_a Wrote: I have a repo with all popular plugins for this

https://github.com/GetSimpleCMS/Plugins/...er/plugins

1. Please consider adding Pagify to your Plugins Repo.

2. Your website tablatronix.com is showing Warning: Potential Security Risk Ahead Error Message in the browser.

With Best Wishes,
Reply
#18
my website is down and has no cert, i need to fix that

added pagify
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#19
I am always using Let's Encrypt they always work.
Reply
#20
Yeah I moved hosts and never fixed it up, I need to figure out how to use that on shared hosts, it says i can upload a cert
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#21
lol I missed the option to auto install letsencrypt doh
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#22
(2022-10-28, 02:22:53)shawn_a Wrote: I need plugins to fix, give me examples

Hi Shawn,

I'd like to report warnings on php7.4 for plugins

1. sa_toc_anchors.php, which makes use of create_function(...,...)
This function internally used eval() and was considered a security risk, while also being global, scopeless, not garbage collectable, ... . Under php7 I get a warning and under php8 a fatal error:
 Fatal error: Uncaught Error: Call to undefined function create_function() in /.../plugins/sa_toc_anchors.php:45
Any suggestions for replacement code?

2. (already fixed in repo) plugins/i18n_navigation/frontend.class.php: old style constructor near 350

3. plugins/sa_hook_components:74 eval'd code on l64, use of undefined constant trim

4. plugins/i18n_base/frontend.class.php(127) : eval()'d code on line 21

Hopefully my site will run fine as soon as the above are fixed.

FYI, I use the following plugins on my site:
Cookies Plugin by Cumbe
FAQ by Vlcek
GSMaintenance
GSPlugin Installer by Helge Sverre
GS_Shortcodes by Mike Swan
HitCount
I18NBase
I18N
I18Search
ItemManager
SA_hook Components
SA_toc_anchors
Theme Highlighter
Multi User by Mike Henken

p.s. I am thrilled that GS is again moving ahead with more people stepping in to help out.
Will your plugin repository also include updated versions?

BTW, I read that php 8 will also only have a short life. My hosting already kills php 7.x on Nov 1, '22; something similar will happen next year, I am afraid. How long before php (and its function library) can evolve without further code-breaking changes?
Reply
#23
Yes I am already updating the repo, and i have rector setup to auto migrate anything in it
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply
#24
(2022-11-01, 12:24:29)shawn_a Wrote: Yes I am already updating the repo, and i have rector setup to auto migrate anything in it

Something new or you left this? People want use GS, if you don't have time, we understand, but new and old users can't wait.
Reply
#25
what?
NEW: SA Admin Toolbar Plugin | View All My Plugins
- Shawn A aka Tablatronix
Reply




Users browsing this thread: 2 Guest(s)