Image upload failures after server PHP update

[gsimon]

Oh, my! What have you inherited? (Aside: if you wrap code with the tags [ code ] ... [ /code ] – leave out the spaces – you get a much more readable result.)

If you haven't already, make a full backup of what you have at the moment (e.g., ftp to your computer).

That sa_welcome.php file is clearly a hacked-together plugin to provide custom tabs for managing litters, but without much finesse. At least remove the closing php tag at the end of the file and change the plugin name and description to something relevant.

You have two versions of the Item(s) Manager, which is unlikely to be a good thing. Disable one of them (probably the older one – but you may not be able to go back).

Disable non-essential plugins:

• Custom Admin CSS
  
• (Innovation theme plugin – depending on the theme requirements, you may have to enable this again)
  
• SA PageTime Plugin
  
• Theme Highlighter
  

You still have a couple of outdated plugins, so bring those up to date.

I have no experience of the Items Manager plugins, so I can't help you there. I don't know what the implications are of having two versions installed.

If this site were my responsibility, I'd look at migrating the existing content to a fresh installation of GS, but there may be other customisations under the skin, so it's going to be a risky business. Good luck!

@Bigin: those lines are already in the file.

Edit to add: Crossed with Shawn's post. @shawn_a: how could you! ;P

Did you try just turning off php errors display? Or did you enable them to debug the actual issue? Errors rather notices and warnings are not errors but they will break cookies and ajax if you have them enables on production sites

Naturally I backed this (and the whole site) up before edits.  I'm also careful enough to usually make a backup of each file before I edit so that rollback is quick, if needed.  I disable the plugins you mentioned and removed the closing php tag too.  Also added the suggested code from @Bigin.  Essentially, I've followed all the suggestions, but the upload still fails. I'd like to do a fresh install of GS, but I'm reluctant to do so until I am more familiar with it.  For now, it is simply imperative that I get the upload function working again.  Later, I will be considering a fresh install when I can roll back to a working "version" should I encounter issues.  Actually, in the long run, the client would like the entire site revised, but for now we'll all be happy just fixing the existing one.